Skip to content

Commit

Permalink
Corrects the S3SinkStack for AWS testing.
Browse files Browse the repository at this point in the history
The S3SinkStack was not in use and didn't quite work. This corrects it so that we can use it to automate the tests for the S3 sink in GitHub.

Signed-off-by: David Venable <[email protected]>
  • Loading branch information
dlvenable committed Sep 4, 2024
1 parent 8eef2f6 commit 1dd6dcd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions testing/aws-testing-cdk/bin/aws-testing-cdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import * as cdk from 'aws-cdk-lib';
import {GitHubAccessStack} from '../lib/common/GitHubAccessStack';
import {SecretsManagerStack} from '../lib/aws-secrets-manager/SecretsManagerStack';
import {KmsStack} from '../lib/common/KmsStack';
import {S3SinkStack} from "../lib/s3/S3SinkStack";

Check failure on line 7 in testing/aws-testing-cdk/bin/aws-testing-cdk.ts

View workflow job for this annotation

GitHub Actions / verify

Strings must use singlequote

const app = new cdk.App();

Expand All @@ -16,3 +17,7 @@ new KmsStack(app, 'CommonKmsStack', {
new SecretsManagerStack(app, 'SecretsManagerStack', {
testingRole: githubStack.gitHubActionsTestingRole
});

new S3SinkStack(app, 'S3SinkStack', {
testingRole: githubStack.gitHubActionsTestingRole
});
2 changes: 1 addition & 1 deletion testing/aws-testing-cdk/lib/s3/S3SinkStack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class S3SinkStack extends Stack {
constructor(scope: Construct, id: string, props: S3SinkStackProps) {
super(scope, id, props);

new Bucket(this, 'MyBucket', {
this.bucket = new Bucket(this, 'DataPrepperSinkTest', {
removalPolicy: RemovalPolicy.DESTROY,
lifecycleRules: [
{
Expand Down

0 comments on commit 1dd6dcd

Please sign in to comment.