Move SSI codelists to OxHPRU#3076
Open
Jongmassey wants to merge 1 commit into
Open
Conversation
d95f591 to
92af60d
Compare
rw251
reviewed
May 20, 2026
|
|
||
| def unpublish_codelist_versions(codelists): | ||
| for codelist in codelists: | ||
| for version in codelist.versions.filter(status=Status.UNDER_REVIEW): |
Contributor
There was a problem hiding this comment.
Should that be filtering to PUBLISHED codelists?
rw251
reviewed
May 20, 2026
| codelists = [ | ||
| codelist | ||
| for codelist in from_org.codelists.filter(coding_system_id="opcs4") | ||
| if not reverse |
Contributor
There was a problem hiding this comment.
Doesn't this mean when reverse==True that codelists is empty?
Contributor
Author
There was a problem hiding this comment.
ah yes, need to switch the and for an or there
Contributor
|
A couple of comments inline. Also, just to confirm, the set of UNDER_REVIEW opcs4 codelists under ukhsa is exactly the set of codelists to move? |
The surgical site OPCS4 codelists previously bulk uploaded to the `ukhsa` org were requested to be moved to the `OxHPRU` org and to be published. This data migration performs both these actions with provision for it to be reversed if necessary
92af60d to
53d8edf
Compare
rw251
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The surgical site OPCS4 codelists previously bulk uploaded to the
ukhsaorg were requested to be moved to theOxHPRUorg and to be published.This data migration performs both these actions with provision for it to be reversed if necessary
Fixes #3066