New recipe to adopt Lombok setter method names #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/java/migrate/lombok/LombokUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lombok/LombokUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lombok/LombokUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lombok/LombokUtils.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/lombok/NormalizeSetterTest.java
Outdated
Show resolved
Hide resolved
timo-a
force-pushed
the
lombok/normalize-setter
branch
from
2e4e61d to
1024a1e
Compare
3 tasks
Comment on lines
32
to
33
| import java.util.List; | ||
| import java.util.StringJoiner; |
There was a problem hiding this comment.
Suggested change
| import java.util.List; | |
| import java.util.StringJoiner; | |
| import java.util.List; |
timo-a
force-pushed
the
lombok/normalize-setter
branch
from
52dd329 to
1486b98
Compare
src/main/java/org/openrewrite/java/migrate/lombok/NormalizeSetter.java
Outdated
Show resolved
Hide resolved
|
The rename suggested here, as well as the other fixes there can likely be applied here as well for consistency |
…java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…terTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timo-a
force-pushed
the
lombok/normalize-setter
branch
from
6c8d03e to
54502e8
Compare
src/main/java/org/openrewrite/java/migrate/lombok/AdoptLombokSetterMethodNames.java
Outdated
Show resolved
Hide resolved
timo-a
changed the title
timo-a
changed the title
src/main/java/org/openrewrite/java/migrate/lombok/AdoptLombokSetterMethodNames.java
Outdated
Show resolved
Hide resolved
…etterMethodNames.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
approved these changes
Jul 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably best to work on that one first and then come back here.