Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Add missing deps for virtualenv environments (#253) #274

Merged

Conversation

Steve-Roderick
Copy link
Contributor

* Add `cartopy` for test `examples/notebooks/Multi-Volume-Concatenation.ipynb`.
* Add `boto3` for test `examples/notebooks/Read-plot-Sigmet-data-from-AWS.ipynb`.
* Add `zarr` for test `examples/notebooks/multiple-sweeps-into-volume-scan.ipynb`.
* Add `s3fs` for test `examples/notebooks/Read-plot-Sigmet-data-from-AWS.ipynb`.
* Add `open_radar_data` for sample data sets used in unittests.
* Add `notebook` and `nbconvert` for unittesting jupyter notebooks.
* Add note to CONTRIBUTING.md referencing OS dependency for `ffmpeg`

@Steve-Roderick
Copy link
Contributor Author

First time contributor here.

  • I did not add any new tests as I think adding a Dockerfile and using docker or podman to verify the environment is probably overkill.
  • I did not edit the history.md file because this change is not really a functional change. Let me know if you'd like me to add a line item to history.md.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.58%. Comparing base (059b5bf) to head (8458255).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files          26       26           
  Lines        5082     5082           
=======================================
  Hits         4756     4756           
  Misses        326      326           
Flag Coverage Δ
notebooktests 79.24% <ø> (ø)
unittests 93.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmuehlbauer
Copy link
Collaborator

kmuehlbauer commented Feb 14, 2025

Thanks @Steve-Roderick for this PR. Until there will, eventually, be an established standard on how to provide these kind of things within pyproject.toml this is a good way to provide the necessary information.

And, although this is no change in functionality, it fixes an issue and is making user experience better. So please add an entry to history.md.

@Steve-Roderick Steve-Roderick force-pushed the update-deps-for-virtualenv branch 2 times, most recently from b72557e to 8458255 Compare February 18, 2025 01:28
    * Add `cartopy` for test `examples/notebooks/Multi-Volume-Concatenation.ipynb`.
    * Add `boto3` for test `examples/notebooks/Read-plot-Sigmet-data-from-AWS.ipynb`.
    * Add `zarr` (2.x) for test `examples/notebooks/multiple-sweeps-into-volume-scan.ipynb`.
    * Add `s3fs` for test `examples/notebooks/Read-plot-Sigmet-data-from-AWS.ipynb`.
    * Add `open_radar_data` for sample data sets used in unittests.
    * Add `notebook` and `nbconvert` for unittesting jupyter notebooks.
    * Add note to CONTRIBUTING.md referencing OS dependency for `ffmpeg`
    * Add history.md entry
@Steve-Roderick
Copy link
Contributor Author

Sounds good - thank you.

  • I added an entry to the history.md
  • Previously one test was failing because I did not pin the zarr dependency to 2.x and if you use zarr 3.x there is a test failure.
    --
    I forced pushed an amended commit.

Thanks again.

@kmuehlbauer kmuehlbauer merged commit eebe778 into openradar:main Feb 19, 2025
12 checks passed
@kmuehlbauer
Copy link
Collaborator

Thanks @Steve-Roderick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Several dependencies are missing when running the tests
2 participants