Improve parser error messages #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
hodgestar
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to report information about ANTLR failures, when this information is available. Docs for the antlr4 Python implementation are a bit spotty, but at least in the Java version the
BailErrorStrategywill result in aParseCancellationExceptionthat carries more specific information in its arguments. My experience has been that it is easy to provide a message indicating where this failure is noticed, although this may not be the root cause of the parse failure.The changes in this PR assume that
OpenPulseParsingErroris user-facing, so that putting information in a human-readable message is appropriate. Alternatively I could imagine adding a field to the exception to carry this information.