-
Notifications
You must be signed in to change notification settings - Fork 165
Standardize block displayName and description fields with consistent style and verb forms #1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 4 commits
5854870
7e2b25e
98be791
9c1587e
ea3936d
b705558
e7bab81
ccfd5e9
4cce6c2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,12 +3,12 @@ import { Property } from '@openops/blocks-framework'; | |
| export function virtualTagsProperty() { | ||
| return { | ||
| useVirtualTag: Property.Checkbox({ | ||
| displayName: 'Filter by virtual tags', | ||
| displayName: 'Filter by Virtual Tags', | ||
| required: false, | ||
| }), | ||
| virtualTag: Property.DynamicProperties({ | ||
| displayName: 'Virtual tag filters', | ||
| description: 'Each virtual tag represents a collection of custom tags.', | ||
| displayName: 'Virtual Tag Filters', | ||
| description: 'Each virtual tag represents a collection of custom tags', | ||
| required: true, | ||
| refreshers: ['useVirtualTag'], | ||
| props: async ({ useVirtualTag }): Promise<{ [key: string]: any }> => { | ||
|
|
@@ -18,20 +18,20 @@ export function virtualTagsProperty() { | |
|
|
||
| return { | ||
| uuid: Property.LongText({ | ||
| displayName: '(Virtual tag) uuid', | ||
| description: '', | ||
| displayName: '(virtual Tag) Uuid', | ||
| description: 'UUID of the virtual tag to filter by', | ||
| required: true, | ||
| }), | ||
|
|
||
| eq: Property.Array({ | ||
| displayName: '(Virtual tag) Equal values', | ||
| description: 'List of values to be checked for equality.', | ||
| displayName: '(virtual Tag) Equal Values', | ||
|
||
| description: 'List of values to be checked for equality', | ||
| required: false, | ||
| }), | ||
|
|
||
| like: Property.Array({ | ||
| displayName: '(Virtual tag) Like values', | ||
| description: 'List of values to check if they are like.', | ||
| displayName: '(virtual Tag) Like Values', | ||
|
||
| description: 'List of values to check if they are like', | ||
| required: false, | ||
| }), | ||
| }; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ export const getRecommendationsCustomAction = createAction({ | |
| auth: anadotAuth, | ||
| name: 'get_recommendations', | ||
| description: 'Get custom Umbrella recommendations', | ||
| displayName: 'Get Recommendations (custom settings)', | ||
| displayName: 'Get Recommendations (custom Settings)', | ||
|
||
| isWriteAction: false, | ||
| props: { | ||
| accounts: accountProperty(), | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ export const getCommitmentsInventoryAction = createAction({ | |
| props: { | ||
| provider: Property.StaticDropdown({ | ||
| displayName: 'Provider', | ||
| description: 'The cloud provider to fetch commitments for.', | ||
| description: 'The cloud provider to fetch commitments for', | ||
| required: true, | ||
| options: { | ||
| options: [ | ||
|
|
@@ -26,23 +26,23 @@ export const getCommitmentsInventoryAction = createAction({ | |
| startDate: Property.ShortText({ | ||
| displayName: 'Start Date', | ||
| description: | ||
| 'The start date for the commitment inventory query (Format: yyyy-MM-dd).', | ||
| 'The start date for the commitment inventory query (Format: yyyy-MM-dd)', | ||
| required: true, | ||
| }), | ||
| endDate: Property.ShortText({ | ||
| displayName: 'End Date', | ||
| description: | ||
| 'The end date for the commitment inventory query (Format: yyyy-MM-dd).', | ||
| 'The end date for the commitment inventory query (Format: yyyy-MM-dd)', | ||
| required: true, | ||
| }), | ||
| search: Property.ShortText({ | ||
| displayName: 'Search', | ||
| description: 'Search term to filter commitments.', | ||
| description: 'Search term to filter commitments', | ||
| required: false, | ||
| }), | ||
| orderBy: Property.StaticDropdown({ | ||
| displayName: 'Order By', | ||
| description: 'Field to order results by.', | ||
| displayName: 'Order by', | ||
|
||
| description: 'Field to order results by', | ||
| required: false, | ||
| options: { | ||
| options: [ | ||
|
|
@@ -67,19 +67,19 @@ export const getCommitmentsInventoryAction = createAction({ | |
| }), | ||
| desc: Property.Checkbox({ | ||
| displayName: 'Descending Order', | ||
| description: 'Sort in descending order.', | ||
| description: 'Sort in descending order', | ||
| required: false, | ||
| defaultValue: true, | ||
| }), | ||
| page: Property.Number({ | ||
| displayName: 'Page', | ||
| description: 'Page number for pagination.', | ||
| description: 'Page number for pagination', | ||
| required: false, | ||
| defaultValue: 1, | ||
| }), | ||
| pageSize: Property.Number({ | ||
| displayName: 'Page Size', | ||
| description: 'Number of items per page (1-10000).', | ||
| description: 'Number of items per page (1-10000)', | ||
| required: false, | ||
| defaultValue: 10, | ||
| }), | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot should be '(Virtual Tag) UUID'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to '(Virtual Tag) UUID' in ea3936d