Repository navigation
Build the OWA natively on Apple Silicon: Node 22.20.0, frontend-maven-plugin 1.15.4 - #120
Merged
Merged
Conversation
…-plugin 1.15.4 frontend-maven-plugin 1.6 requests node-v14.7.0-darwin-arm64.tar.gz on an arm64 Mac, which Node never published (darwin-arm64 builds start at v16), so `mvn package` failed with a 404 in bedmanagement-owa unless the frontend build was skipped, leaving the omod's OWA without build/app.js and build/vendor.js. Move to Node v22.20.0 (current LTS, the version coreapps uses), published for darwin-arm64 and linux-x64, and to frontend-maven-plugin 1.15.4, which fetches the native arm64 Node for Node 16+. The OWA toolchain (webpack 3, babel 6, jest 21, yarn 1.3.2) is unchanged and builds the same bundles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



On an arm64 Mac,
mvn packagefails inbedmanagement-owa:frontend-maven-plugin 1.6 maps
aarch64todarwin-arm64, but Node 14.7.0 was never published fordarwin-arm64. Node only ships darwin-arm64 builds from v16 onwards. Until now, the only way to build was
-Dskip.installnodenpm -Dskip.installyarn -Dskip.yarn -Dskip.npm. That produces an omod whosebedmanagement.owahas nobuild/app.jsorbuild/vendor.js.Change (
owa/pom.xmlonly)v14.7.0->v22.20.0: the current LTS, and the version coreapps moved to in openmrs-module-coreapps#522.It is published for both darwin-arm64 and linux-x64.
1.6->1.15.4, the last 1.x release (requires Maven 3.6+). Since 1.12 the plugin fetchesthe native arm64 Node build for Node 16+ on Apple Silicon, instead of the x64 build under Rosetta.
v1.3.2.yarn.lock,package.jsonand webpack 3 / babel 6 / jest 21 are unchanged.None of them is a native addon, and there is no node-sass.
Verified
mvn clean packagesucceeds. The plugin downloadsnode-v22.20.0-darwin-arm64.tar.gz, and all 56 OWA jest tests pass.web/module/owas/bedmanagement.owacontainsbuild/app.jsandbuild/vendor.js.app/buildoutput.linux/amd64node:22.20.0container, which matches the ubuntu CI runner.The same change applies to
master, whoseowa/pom.xmlpins the same plugin and Node versions.🤖 Generated with Claude Code