-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WZDx reference #96
base: dev
Are you sure you want to change the base?
Conversation
| Name | Type | Required/Optional | Description | | ||
| ------ | ------ | ------------------- | ------------- | | ||
| `wzdx_feed_url` | URL | Required | An identifier for the source of the publicly accessible WZDx feed. This MUST be a full HTTPS URL pointing to the data feed which contains more information about the underlying work zone impacting the CDS place. | | ||
| `wzdx_road_event_feature_id` | String | Required | The `id` of a WZDx [RoadEventFeature](https://github.com/usdot-jpo-ode/wzdx/blob/main/spec-content/objects/RoadEventFeature.md#roadeventfeature-object-geojson-feature) that impacts the use of a curb zone. In case multiple road event `wzdx_id`s are needed, it would be provided in another object with another `wzdx_feed_url`. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One update to multiple ids:
"In case multiple id
s are needed, it should be provided in another object with another wzdx_feed_url
"
I don't think we would need describe what the id is again, and this wording provides guidance by using should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this should be updated to wzdx_road_event_feature_ids and made into an array of Strings. I'll make the edit.
I think this is in good shape and continues to make sense in aligning CDS and WZDx for relevant work zones that impact curb areas. @jlarsonOmahaNE I suggest you move forward with a PR to add a corollary optional data element in WZDx to reference CDS ids. |
There is now a PR in WZDx to add references to CDS here usdot-jpo-ode/wzdx#326 |
Approved as part of WZDx v4.2 |
Explain pull request
Adding a reference to WZDx data feeds in CDS's Curbs API per issue #74
Is this a breaking change
Impacted Spec
Which API(s) will this pull request impact?
Curbs