fix: #14 | Add quotes around custom types containing space in their names #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brigon-clever-age
force-pushed
the
fix/14-attributes-containing-spaces
branch
4 times, most recently
from
afdc131 to
b03acff
Compare
… in their names. Add possibility to specify the meta directory as a commande line option with --metaPath ./site-meta/meta/ --cartridgePath ./cartridges/ and --attrsOutputPath @types/dw/ Remove \r from descriptions to keep only \n to fix a display issue on windows
brigon-clever-age
force-pushed
the
fix/14-attributes-containing-spaces
branch
from
b03acff to
b8a2873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :-)
I applied a fix for issue #14 , and I also added the ability to specify the meta directory as a command line argument, to allow generating / updating types on a CI pipeline for example ;-)
Example:
npm run sfcc-dts-updateattrs -- --metaPath ./site-meta/meta/