Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade k8s deps 1.30 #1896

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

ABNER-1
Copy link
Member

@ABNER-1 ABNER-1 commented Jan 24, 2025

Ⅰ. Describe what this PR does

  1. improve go version to 1.22
  2. update k8s deps to 1.30
  3. generate client/informer/deepcopy/openapi using kube_codegen.sh
  4. use TypedEnqueueRequestForObject to explicitly define the input for the event handler.

Ⅱ. Does this pull request fix one issue?

fixes #1903

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@ABNER-1 ABNER-1 force-pushed the upgrade-k8s-1.30 branch 6 times, most recently from 823989e to 3224c6d Compare January 26, 2025 08:10
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 24.16667% with 273 lines in your changes missing coverage. Please review.

Project coverage is 37.37%. Comparing base (0d0031a) to head (88a1af5).
Report is 152 commits behind head on master.

Files with missing lines Patch % Lines
...troller/imagepulljob/imagepulljob_event_handler.go 0.00% 23 Missing ⚠️
...tentpodstate/persistent_pod_state_event_handler.go 0.00% 21 Missing ⚠️
...troller/nodepodprobe/nodepodprobe_event_handler.go 9.52% 19 Missing ⚠️
...troller/broadcastjob/broadcastjob_event_handler.go 0.00% 16 Missing ⚠️
...troller/ephemeraljob/ephemeraljob_event_handler.go 0.00% 16 Missing ⚠️
...rcedistribution/resourcedistribution_controller.go 0.00% 14 Missing ⚠️
...g/controller/statefulset/statefulset_controller.go 0.00% 13 Missing ⚠️
...kg/controller/nodeimage/nodeimage_event_handler.go 0.00% 12 Missing ⚠️
pkg/controller/daemonset/daemonset_controller.go 0.00% 10 Missing ⚠️
...availablebudget/podunavailablebudget_controller.go 0.00% 10 Missing ⚠️
... and 33 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1896       +/-   ##
===========================================
- Coverage   47.91%   37.37%   -10.54%     
===========================================
  Files         162      407      +245     
  Lines       23491    36153    +12662     
===========================================
+ Hits        11256    13513     +2257     
- Misses      11014    21249    +10235     
- Partials     1221     1391      +170     
Flag Coverage Δ
unittests 37.37% <24.16%> (-10.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ABNER-1 ABNER-1 force-pushed the upgrade-k8s-1.30 branch 2 times, most recently from 160e5f5 to a90544f Compare February 5, 2025 02:18
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@ABNER-1 ABNER-1 force-pushed the upgrade-k8s-1.30 branch 5 times, most recently from a8c1a9d to 33a57ab Compare February 6, 2025 01:57
Signed-off-by: Abner-1 <[email protected]>
@zmberg
Copy link
Member

zmberg commented Feb 7, 2025

/lgtm

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@furykerry furykerry merged commit 58fd993 into openkruise:master Feb 7, 2025
51 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Bump K8s dependency to 1.30
3 participants