Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kim_SW_Si.ipynb #202

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Update kim_SW_Si.ipynb #202

merged 1 commit into from
Feb 25, 2025

Conversation

ProfessorMiller
Copy link
Contributor

@ProfessorMiller ProfessorMiller commented Feb 23, 2025

Summary

Include a summary of major changes in bullet points:

  • Feature 1
  • Fix 1

Additional dependencies introduced (if any)

  • List all new dependencies needed and justify why.

TODO (if any)

If this is a work-in-progress, write something about what else needs to be done.

  • Feature 1 supports A, but not B.

Checklist

Before a pull request can be merged, the following items must be checked:

  • Make sure your code is properly formatted. isort and black are used for this purpose. The simplest way is to use pre-commit. See instructions here.
  • Doc strings have been added in the Google docstring format on your code.
  • Type annotations are highly encouraged. Run mypy to type check your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

Note that the CI system will run all the above checks. But it will be much more efficient if you already fix most errors prior to submitting the PR.

@mjwen mjwen merged commit a917d24 into openkim:main Feb 25, 2025
1 of 7 checks passed
@mjwen
Copy link
Collaborator

mjwen commented Feb 25, 2025

@ProfessorMiller Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants