Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for newer modules #164

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Added tests for newer modules #164

merged 3 commits into from
Feb 23, 2024

Conversation

ipcamit
Copy link

@ipcamit ipcamit commented Feb 20, 2024

  • Fixed but in voigt stress conversion functions
  • Fixed implicit fingerprinting bug in configuration transforms
  • Fixed documentation and typing inaccuracies
  • Added tests for ASE dataset/configuration interactions
  • Added tests utils (stress functions currently)
  • Added tests for configuration transformations
    • libdescriptor integrations and comparison with older modules
    • graph generations
    • Abstract ConfigurationTransform class
  • Added tests for PropertyTransform

I think this covers test cases for most of the newer contributions. Let me know if I missed something. I would start working on the trainer modules now.

@mjwen
Copy link
Collaborator

mjwen commented Feb 23, 2024

Looks great! Just have a minor question. See above.

@mjwen mjwen merged commit b4fa779 into openkim:v1 Feb 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants