Skip to content

7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toddjonker
Copy link
Contributor

@toddjonker toddjonker commented Jun 17, 2025

This is a clean backport of d3f3011, originally authored by @archiecobbs and reviewed by @jaikiran

I believe this should be covered by CSR https://bugs.openjdk.org/browse/JDK-8340729 though (as noted there) the description and issue metadata differ regarding JDK21.

Testing:

  • New regression test fails without the fix, passes with it
  • linux-x86_64-server-release: headless tiers 1-3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8340729 to be approved
  • JDK-7036144 needs maintainer approval

Issues

  • JDK-7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream (Bug - P4 - Approved)
  • JDK-8340729: GZIPInputStream readTrailer uses faulty available() test for end-of-stream (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1897/head:pull/1897
$ git checkout pull/1897

Update a local copy of the PR:
$ git checkout pull/1897
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1897/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1897

View PR using the GUI difftool:
$ git pr show -t 1897

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1897.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2025

👋 Welcome back toddjonker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

@toddjonker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport d3f3011d56267360d65841da3550eca79cf1575b 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream Jun 17, 2025
@openjdk
Copy link

openjdk bot commented Jun 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jun 17, 2025
@openjdk openjdk bot added approval and removed approval csr Pull request needs approved CSR before integration labels Jun 23, 2025
@toddjonker toddjonker marked this pull request as ready for review June 24, 2025 20:19
@openjdk
Copy link

openjdk bot commented Jun 24, 2025

⚠️ @toddjonker This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Jun 24, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant