Skip to content

8348328: Update IANA Language Subtag Registry to Version 2025-05-15 #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RadekCap
Copy link
Contributor

@RadekCap RadekCap commented Jun 4, 2025

Backport of JDK-8348328 - Update IANA Language Subtag Registry to Version 2025-05-15

The IANA Functions Operator has updated the language subtag registry to "2025-05-15".

Clean backport.
Passed tier1 tests.

There are the same failures on the master branch in a local run:

compiler/escapeAnalysis/TestFindInstMemRecursion.java: 
test result: Failed. Execution failed: `main' threw exception: java.awt.AWTError: Can't connect to X11 window server using ':0' as the value of the DISPLAY variable.

serviceability/sa/ClhsdbPstack.java#core
test result: Error. Program `/home/rcap/git/github/jdk21u-dev/build/linux-x86_64-server-release/images/jdk/bin/java' timed out (timeout set to 1920000ms, elapsed time including timeout handling was 1920178ms).

serviceability/sa/ClhsdbPstack.java#process
test result: Error. Program `/home/rcap/git/github/jdk21u-dev/build/linux-x86_64-server-release/images/jdk/bin/java' timed out (timeout set to 480000ms, elapsed time including timeout handling was 480217ms).

serviceability/sa/TestJhsdbJstackMixed.java:
test result: Error. "driver" action timed out with a timeout of 480 seconds on agent 58

java/foreign/nested/TestNested.java
test result: Failed. Compilation failed: Compilation failed

GH Actions are passing, Windows failures are unrelated.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8348328 needs maintainer approval

Issue

  • JDK-8348328: Update IANA Language Subtag Registry to Version 2025-05-15 (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1846/head:pull/1846
$ git checkout pull/1846

Update a local copy of the PR:
$ git checkout pull/1846
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1846/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1846

View PR using the GUI difftool:
$ git pr show -t 1846

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1846.diff

Using Webrev

Link to Webrev Comment

@RadekCap RadekCap changed the title Backport f318868268f32934a2f0c4e26a6c75360d8e74b1 Backport 9bcfa2f381bbc802b9d46721e5cbdeed2d90d86b Jun 4, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2025

👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 4, 2025

⚠️ @RadekCap the commit 9bcfa2f381bbc802b9d46721e5cbdeed2d90d86b does not refer to an issue in project JDK.

@RadekCap RadekCap changed the title Backport 9bcfa2f381bbc802b9d46721e5cbdeed2d90d86b Backport f318868268f32934a2f0c4e26a6c75360d8e74b1 Jun 4, 2025
@openjdk openjdk bot changed the title Backport f318868268f32934a2f0c4e26a6c75360d8e74b1 8348328: Update IANA Language Subtag Registry to Version 2025-05-15 Jun 4, 2025
@openjdk
Copy link

openjdk bot commented Jun 4, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 4, 2025

⚠️ @RadekCap This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2025

Webrevs

@RadekCap
Copy link
Contributor Author

RadekCap commented Jun 4, 2025

/approval request Update IANA Language Subtag Registry to Version 2025-05-15

@openjdk
Copy link

openjdk bot commented Jun 4, 2025

@RadekCap
8348328: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 4, 2025
@RadekCap
Copy link
Contributor Author

RadekCap commented Jun 5, 2025

/approval request Update IANA Language Subtag Registry to Version 2025-05-15

@openjdk
Copy link

openjdk bot commented Jun 5, 2025

@RadekCap
8348328: The approval request was already up to date.

@GoeLin
Copy link
Member

GoeLin commented Jun 5, 2025

HI @RadekCap
if this gets approved for 24u, we want to get this into the July update.
Thus, in this case, we will need a PR agains jdk21u, not jdk21u-dev.
But we need to wait on the decision for 24u.
I remove the approval tag in the meantime. Please label again if it get's denied for 24u (or does not make the July update).
If it makes the July update of 24u, please open a PR agains jdk21u and label jdk21u-critical-request.

@openjdk openjdk bot removed the approval label Jun 5, 2025
@RadekCap
Copy link
Contributor Author

RadekCap commented Jun 5, 2025

Hi @GoeLin,

Yes, I'm waiting for 24u approval. Let's see which will come sooner: the July update or 24u approval.
If approved first, I'll create a PR against 24u and close this one. The same situation will likely apply to 17 (PR already exists and waiting for 24u, 21u approval), and later to 11.

@gnu-andrew
Copy link
Member

HI @RadekCap if this gets approved for 24u, we want to get this into the July update. Thus, in this case, we will need a PR agains jdk21u, not jdk21u-dev. But we need to wait on the decision for 24u. I remove the approval tag in the meantime. Please label again if it get's denied for 24u (or does not make the July update). If it makes the July update of 24u, please open a PR agains jdk21u and label jdk21u-critical-request.

I don't see anything going into 24u at this juncture. I can't see a closure message on the jdk-updates-dev mailing list, but apparently it entered RDP 2 as long ago as April 22nd, right after the last release. July's release will be the last update for 24u, before 25 is released in September.

If we do want to get this into July ourselves, we should do so ASAP as the freeze is imminent (a week today for 17u & 21u, the Friday for 11u)

Generally, I would say give the latest release two weeks and proceed with the LTS releases if nothing is approved in that time frame.

@gnu-andrew
Copy link
Member

/approval request Update IANA Language Subtag Registry to Version 2025-05-15

Approval requests should really explain why this should be backported to the update, the expected risk and testing that has been done, so that the approver can make an informed decision.

@RadekCap
Copy link
Contributor Author

Updating the approval request to make the review easier.

/approval request Update IANA Language Subtag Registry to Version 2025-05-15 Update to the latest IANA version. Clean backport. Passed tier1 tests. Passed gtests.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

@RadekCap
8348328: The approval request has been updated successfully.

@openjdk openjdk bot added the approval label Jun 17, 2025
@RadekCap
Copy link
Contributor Author

Converting to draft as I'll use to add to the following CPU release.

@RadekCap RadekCap marked this pull request as draft June 18, 2025 11:18
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 18, 2025
@RadekCap
Copy link
Contributor Author

@GoeLin Hi, please review 21u PR if you have time, so we can include it in the following CPU release:

openjdk/jdk21u#465

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants