-
Notifications
You must be signed in to change notification settings - Fork 129
8348328: Update IANA Language Subtag Registry to Version 2025-05-15 #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Update IANA Language Subtag Registry to Version 2025-05-15 |
/approval request Update IANA Language Subtag Registry to Version 2025-05-15 |
HI @RadekCap |
Hi @GoeLin, Yes, I'm waiting for 24u approval. Let's see which will come sooner: the July update or 24u approval. |
I don't see anything going into 24u at this juncture. I can't see a closure message on the jdk-updates-dev mailing list, but apparently it entered RDP 2 as long ago as April 22nd, right after the last release. July's release will be the last update for 24u, before 25 is released in September. If we do want to get this into July ourselves, we should do so ASAP as the freeze is imminent (a week today for 17u & 21u, the Friday for 11u) Generally, I would say give the latest release two weeks and proceed with the LTS releases if nothing is approved in that time frame. |
Approval requests should really explain why this should be backported to the update, the expected risk and testing that has been done, so that the approver can make an informed decision. |
Updating the approval request to make the review easier. /approval request Update IANA Language Subtag Registry to Version 2025-05-15 Update to the latest IANA version. Clean backport. Passed tier1 tests. Passed gtests. |
Converting to draft as I'll use to add to the following CPU release. |
@GoeLin Hi, please review 21u PR if you have time, so we can include it in the following CPU release: Thank you. |
Backport of JDK-8348328 - Update IANA Language Subtag Registry to Version 2025-05-15
The IANA Functions Operator has updated the language subtag registry to "2025-05-15".
Clean backport.
Passed tier1 tests.
There are the same failures on the master branch in a local run:
GH Actions are passing, Windows failures are unrelated.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1846/head:pull/1846
$ git checkout pull/1846
Update a local copy of the PR:
$ git checkout pull/1846
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1846/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1846
View PR using the GUI difftool:
$ git pr show -t 1846
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1846.diff
Using Webrev
Link to Webrev Comment