8356328: Some C2 IR nodes miss size_of() function

[kuaiwei]

Hi all,

This pull request contains a backport of commit 9927ec0b from the openjdk/jdk repository.

The commit being backported was authored by Kuai Wei on 18 May 2025 and was reviewed by Tobias Hartmann and Christian Hagedorn.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8356328 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8356328: Some C2 IR nodes miss size_of() function (Bug - P4 - Rejected)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1814/head:pull/1814
$ git checkout pull/1814

Update a local copy of the PR:
$ git checkout pull/1814
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1814/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1814

View PR using the GUI difftool:
$ git pr show -t 1814

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1814.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kwei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (d0cca21d)
• 01: Full - Incremental (e608088c)
• 00: Full (ce2541ab)

[phohensee]

Looks clean.

[openjdk]

⚠️ @kuaiwei This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[kuaiwei]

@phohensee Thanks for review.

[kuaiwei]

/approval

[openjdk]

@kuaiwei usage: /approval [<id>] (request|cancel) [<text>]

[kuaiwei]

/approval request

[openjdk]

@kuaiwei
8356328: The approval request has been created successfully.

[GoeLin]

Hi @kuaiwei
please give an appropriate approval request comment.
Also please edit the PR description and add an description what you had to edit.

Have a look at https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix
for what should go into the comment.

Then add the label again.

[kuaiwei]

Hi @kuaiwei please give an appropriate approval request comment. Also please edit the PR description and add an description what you had to edit.

Have a look at https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix for what should go into the comment.

Then add the label again.

Thanks for your suggestion.

[kuaiwei]

/approval request for backport 8356328: Some C2 IR nodes miss size_of() function
This bug exists in JDK21u-dev.
The patch is clean and passed tier1 tests.

[openjdk]

@kuaiwei
8356328: The approval request has been updated successfully.

[bridgekeeper]

@kuaiwei This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!