Skip to content

8342934: TYPE_USE annotations printed with error causing "," in toString output #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented May 16, 2025

This backport of JDK-8342934 fixes a bug in TypeMirror#toString output.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8342934 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8342934: TYPE_USE annotations printed with error causing "," in toString output (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1802/head:pull/1802
$ git checkout pull/1802

Update a local copy of the PR:
$ git checkout pull/1802
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1802/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1802

View PR using the GUI difftool:
$ git pr show -t 1802

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1802.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2025

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 16, 2025

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342934: TYPE_USE annotations printed with error causing "," in toString output

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ff165f9f0cf519144d7361b766bcce53d04c518e 8342934: TYPE_USE annotations printed with error causing "," in toString output May 16, 2025
@openjdk
Copy link

openjdk bot commented May 16, 2025

This backport pull request has now been updated with issue from the original commit.

@cushon cushon marked this pull request as ready for review May 16, 2025 16:10
@openjdk
Copy link

openjdk bot commented May 16, 2025

⚠️ @cushon This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 16, 2025
@cushon
Copy link
Contributor Author

cushon commented May 16, 2025

/approval request This fixes a small bug in TypeMirror#toString output with type annotations, which could be encountered more often after the backport of JDK-8341779 to load type annotations from class files. Clean backport, the affected tests pass.

@openjdk
Copy link

openjdk bot commented May 16, 2025

@cushon
8342934: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 16, 2025
@mlbridge
Copy link

mlbridge bot commented May 16, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 6, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2025

@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cushon
Copy link
Contributor Author

cushon commented Jun 16, 2025

/touch

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

@cushon The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant