8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport

[dtmhuang]

Backport for RandomSupport issue. There is a loss of information when using convertSeedBytesToLongs() with a bad seed, causing a lot of the original bytes to be overwritten by 1s. The fix involves using a bitwise AND with the seed before distributing the seed bytes into the result.

Clean backport, ran GHA sanity checks and locally tested tier1, tier2. In tier2, there were 2 failures:
test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java
test/jdk/java/nio/channels/FileChannel/directio/DirectIOTest.java
However, these both failed before the backport as well.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8294509 needs maintainer approval

Issue

• JDK-8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3694/head:pull/3694
$ git checkout pull/3694

Update a local copy of the PR:
$ git checkout pull/3694
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3694/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3694

View PR using the GUI difftool:
$ git pr show -t 3694

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3694.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dtmhuang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (ac0c9567)

[dtmhuang]

will backport the two bugfixes individually