8337506: Disable "best-fit" mapping on Windows command line

[kvergizova]

I'd like to backport this for parity with 11.0.29-oracle.
CSR JDK-8349538 has been approved for 11u.
17u patch applies cleanly, but the test requires a few modifications to work properly:

• replaced native.encoding property with file.encoding, as native.encoding is not present in 11u.
  These two are identical unless file.encoding is overridden on the command line:
  https://github.com/openjdk/jdk17u-dev/blob/master/src/java.base/share/classes/jdk/internal/util/SystemProps.java#L72
• replaced "str".formatted(args) with String.format("str", args), as String::formatted() is not available in 11u. Both methods produce the same result.

The new test passes successfully after applying the patch.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8337506 needs maintainer approval
• Change requires CSR request JDK-8349538 to be approved

Issues

• JDK-8337506: Disable "best-fit" mapping on Windows command line (Bug - P4 - Approved)
• JDK-8349538: Disable "best-fit" mapping on Windows command line (CSR)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3062/head:pull/3062
$ git checkout pull/3062

Update a local copy of the PR:
$ git checkout pull/3062
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3062/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3062

View PR using the GUI difftool:
$ git pr show -t 3062

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3062.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8337506: Disable "best-fit" mapping on Windows command line

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

• 463e25f: 8245545: Disable TLS_RSA cipher suites
• 1939efc: 8213781: web page background renders blue in JEditorPane
• c5cef8c: 8257709: C1: Double assignment in InstructionPrinter::print_stack
• ... and 66 more: https://git.openjdk.org/jdk11u-dev/compare/7ff53b5d990bf8d30df130a88e7c4bf15d591275...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (490caa71)

[bridgekeeper]

@kvergizova This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[kvergizova]

/keepalive

[openjdk]

@kvergizova The pull request is being re-evaluated and the inactivity timeout has been reset.

[bridgekeeper]

@kvergizova This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[kvergizova]

/keepalive

[openjdk]

@kvergizova The pull request is being re-evaluated and the inactivity timeout has been reset.

[bridgekeeper]

@kvergizova This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

Changes look good to me. Thanks for backporting.

[openjdk]

⚠️ @kvergizova This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[kvergizova]

/approval request I'd like to backport it for parity with 11.0.29-oracle.
The backport is clean, but some changes were required for the test to work properly.
CSR JDK-8349538 is approved.

[openjdk]

@kvergizova
8337506: The approval request has been created successfully.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8337506: The approval request has been approved.

[kvergizova]

/integrate

[openjdk]

Going to push as commit b99b989.
Since your change was applied there have been 69 commits pushed to the master branch:

• 463e25f: 8245545: Disable TLS_RSA cipher suites
• 1939efc: 8213781: web page background renders blue in JEditorPane
• c5cef8c: 8257709: C1: Double assignment in InstructionPrinter::print_stack
• ... and 66 more: https://git.openjdk.org/jdk11u-dev/compare/7ff53b5d990bf8d30df130a88e7c4bf15d591275...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kvergizova Pushed as commit b99b989.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.