Skip to content

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Nov 14, 2025

Please review this change to the LockFreeStack utility to allow clients to
use Atomic<T> as the type of the "next" member used in the linked-list
representation of the stack. It also continues to allow clients to use the old
(pre-Atomic<T>) form where the "next" member is volatile. This allows
clients to be updated incrementally after this change, rather than requiring
all clients to be updated in conjunction with the update of this class. Once
all clients have been updated, support for the old form can be removed.

The associated gtests have been updated to use Atomic<T>, with testing of
the old form is no longer being done. The non-updated uses provide some
testing, and that's all expected to go away soon. So parameterizing the gtests
for both forms seems like a bunch of work that will just be deleted soon, with
very little benefit.

Testing: mach5 tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371923: Update LockFreeStack for Atomic<T> (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28329/head:pull/28329
$ git checkout pull/28329

Update a local copy of the PR:
$ git checkout pull/28329
$ git pull https://git.openjdk.org/jdk.git pull/28329/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28329

View PR using the GUI difftool:
$ git pr show -t 28329

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28329.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2025

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 14, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant