-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8353847: Remove extra args to System.out.printf in open/test/jdk/java/net/httpclient tests #24507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/net/httpclient tests
👋 Welcome back serhiysachkov! A progress list of the required criteria for merging this PR into |
@serhiysachkov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@serhiysachkov The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@serhiysachkov while your at it can you fix the issue title (jsk => jdk) and then update the PR title accordingly? Thanks! |
/integrate |
@serhiysachkov |
/sponsor |
Going to push as commit f94a4f7.
Your commit was automatically rebased without conflicts. |
@mahendrachhipa @serhiysachkov Pushed as commit f94a4f7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Remove extra args to System.out.printf in open/test/jsk/java/net/httpclient tests
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24507/head:pull/24507
$ git checkout pull/24507
Update a local copy of the PR:
$ git checkout pull/24507
$ git pull https://git.openjdk.org/jdk.git pull/24507/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24507
View PR using the GUI difftool:
$ git pr show -t 24507
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24507.diff
Using Webrev
Link to Webrev Comment