8353683: [REDO] j.u.l.Handler classes create deadlock risk via synchronized publish() method

[david-beaumont]

8353683: j.u.l.Handler classes create deadlock risk via synchronized publish() method.

1. Remove synchronization of calls to publish() in Handlers in java.util.logging package.
2. Add explanatory comments to various affected methods.
3. Add a test to ensure deadlocks no longer occur.

Note that this change does not address issue in MemoryHandler (see JDK-8349208).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8349920 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8353683: [REDO] j.u.l.Handler classes create deadlock risk via synchronized publish() method (Bug - P4)
• JDK-8349920: j.u.l.Handler classes create deadlock risk via synchronized publish() method (CSR)

Reviewers

• Stuart Marks (@stuart-marks - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24504/head:pull/24504
$ git checkout pull/24504

Update a local copy of the PR:
$ git checkout pull/24504
$ git pull https://git.openjdk.org/jdk.git pull/24504/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24504

View PR using the GUI difftool:
$ git pr show -t 24504

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24504.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back david-beaumont! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@david-beaumont This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353683: [REDO] j.u.l.Handler classes create deadlock risk via synchronized publish() method

Reviewed-by: smarks

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 140 new commits pushed to the master branch:

• 0e223f1: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test
• 2ba80d2: 8353586: Open source several toolkit tests
• e50af6d: 8354090: Refactor import warning suppression in Check.java
• ... and 137 more: https://git.openjdk.org/jdk/compare/6b7b3247b1b247ca38ba51a2c2de924eea9b2aba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stuart-marks) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@david-beaumont The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[david-beaumont]

This is a redo of #23491 with a tiny additional edit to remove an unwanted <p> element in the public JavaDoc (see 772a03e ).

[mlbridge]

Webrevs

• 00: Full (772a03e0)

[liach]

@stuart-marks Can you check this out?

[stuart-marks]

Looks good. I'll suggest that @dfuch sponsor this time. :-D

[dfuch]

OK I ran tier1 and tier2 + logging test and got no failures. @david-beaumont can you integrate and let me know?

[david-beaumont]

/integrate

[openjdk]

@david-beaumont
Your change (at version 772a03e) is now ready to be sponsored by a Committer.

[dfuch]

/sponsor

[openjdk]

Going to push as commit 36e11b6.
Since your change was applied there have been 140 commits pushed to the master branch:

• 0e223f1: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test
• 2ba80d2: 8353586: Open source several toolkit tests
• e50af6d: 8354090: Refactor import warning suppression in Check.java
• ... and 137 more: https://git.openjdk.org/jdk/compare/6b7b3247b1b247ca38ba51a2c2de924eea9b2aba...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch @david-beaumont Pushed as commit 36e11b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.