-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8353007: Open some JComboBox bugs 2 #24496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back achung! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@alisenchung The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@alisenchung |
try { | ||
UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsLookAndFeel"); | ||
} catch (Exception e) { | ||
throw new jtreg.SkippedException("Couldn't load the Windows look and feel."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we treat this an automatic failure -eg JPassFailJFrame.forceFail("...")
Updating and opening some tests
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24496/head:pull/24496
$ git checkout pull/24496
Update a local copy of the PR:
$ git checkout pull/24496
$ git pull https://git.openjdk.org/jdk.git pull/24496/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24496
View PR using the GUI difftool:
$ git pr show -t 24496
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24496.diff
Using Webrev
Link to Webrev Comment