Skip to content

8351152: x86: Remove code blocks that handle UseSSE < 2 #24484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 7, 2025

32-bit x86 was the platform that supported UseSSE < 2. 64-bit x86 baselines on UseSSE >= 2:

#ifdef _LP64
// OS should support SSE for x64 and hardware should support at least SSE2.
if (!VM_Version::supports_sse2()) {
vm_exit_during_initialization("Unknown x64 processor: SSE2 not supported");
}
// in 64 bit the use of SSE2 is the minimum
if (UseSSE < 2) UseSSE = 2;
#endif

After 32-bit x86 code is gone, we can remove all code blocks that are there to support UseSSE < 2.

Additional testing:

  • Linux x86_64 server fastdebug, all

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351152: x86: Remove code blocks that handle UseSSE < 2 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24484/head:pull/24484
$ git checkout pull/24484

Update a local copy of the PR:
$ git checkout pull/24484
$ git pull https://git.openjdk.org/jdk.git pull/24484/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24484

View PR using the GUI difftool:
$ git pr show -t 24484

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24484.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 7, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351152: x86: Remove code blocks that handle UseSSE < 2

Reviewed-by: vlivanov, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@shipilev shipilev force-pushed the JDK-8351152-x86-sse2-everywhere branch from cadc1b8 to f6ee2bd Compare April 9, 2025 08:43
@shipilev shipilev marked this pull request as ready for review April 9, 2025 15:08
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 9, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 9, 2025

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 9, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 10, 2025
Copy link
Contributor

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 10, 2025
@shipilev
Copy link
Member Author

Thank you!

/integrate

@openjdk
Copy link

openjdk bot commented Apr 11, 2025

Going to push as commit cf0308b.
Since your change was applied there have been 26 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 11, 2025
@openjdk openjdk bot closed this Apr 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 11, 2025
@openjdk
Copy link

openjdk bot commented Apr 11, 2025

@shipilev Pushed as commit cf0308b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants