Align payment point create tooltip key with module convention#69
Merged
zikani03 merged 1 commit intorelease/26.04from Apr 18, 2026
Merged
Conversation
PaymentPointsPage used formatMessage('tooltip.createButton') while the
rest of this module — and all other openIMIS modules — use
formatMessage('createButton.tooltip'). The mismatched key diverged
from the established convention used across the platform and made the
tooltip harder to locate when searching module translations.
Rename the translation key to payroll.createButton.tooltip and update
the consumer to match.
|
68 tasks
zikani03
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PaymentPointsPageusedformatMessage('tooltip.createButton')while the rest of this module — and every other openIMIS module — usesformatMessage('createButton.tooltip'). The mismatched key diverged from the established convention used across the platform and made the tooltip harder to locate when searching module translations.This PR renames the translation key to
payroll.createButton.tooltipand updates the consumer to match.Type of Change
Related Issue(s) / Task(s)
Blocked by / related to: openimis/openimis-dist_dkr#99 (this key is exercised by the payment-point E2E tests added in that PR).
Changes
payroll.tooltip.createButton→payroll.createButton.tooltipinsrc/translations/en.jsonPaymentPointsPage.jsto useformatMessage('createButton.tooltip')Behaviour Before / After
tooltip.createButton(diverged key)createButton.tooltip(module convention)No user-visible behaviour changes — this is a key-naming cleanup that aligns with the rest of the module and platform.
Demo
No visible change — the rendered tooltip text is identical.
Checklist
createButton.tooltipconvention used in other openIMIS modulesgrep tooltip.createButtonis clean in this repo)