improve the claim form OP-2586#237
Conversation
|
|
could you please resolve the merge conflicts? |
Aya-OURAG-Speedykom
left a comment
Aya-OURAG-Speedykom
left a comment
There was a problem hiding this comment.
thanks for resolving the conflicts @Blue-B-code unfortunately, the new updated ClaimMasterPanel file contains JSX structure issues, such as missing closing tags (e.g., ), they might be due to merge conflict resolution, please check :
Blue-B-code
force-pushed
the
feature-33756
branch
from
51fc943 to
5f93419
Compare
|
| <Grid container item spacing={2}> | ||
| {/* Section 2: Insuree Information */} | ||
| <Grid item xs={6}> | ||
| <Typography variant="h8" className={classes.sectionHeader}> |
There was a problem hiding this comment.
actually typography variant="h8" doesn't exist in Material UI. Valid variants go up to h6. This won't crash but will render as default body text, so the section headers might not look as intended
| </Grid> | ||
| )} | ||
|
|
||
| {(!!edited.visitType && edited.visitType == REFERRAL) || (!!edited.patientCondition && edited.patientCondition == REFERRAL) ? ( |
There was a problem hiding this comment.
@Blue-B-code the fields are indeed now grouped into sections, which improves the form's readability. However, I found some issues for example, Claim.referHealthFacility is duplicated. When we choose "Referral" as the visit type (or patient condition), the Refer Health Facility picker is rendered twice in the Visit Details section. This is also visible in the code, where the ControlledField with id="Claim.referHealthFacility" appears in two separate places within the same section. One of the two blocks should be removed I'd suggest keeping the first one, as its value logic (with the referFrom fallback) matches the original behavior.
4 participants
When the user opens the claim form, they are faced with many fields to fill in. To make this task easier and improve the UI and UX, we proposed organizing these fields into subsections, as shown in the screenshots.