Skip to content

Add IS_UNIT_TEST_ENV which is required by conditional opensearch document setup #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add IS_UNIT_TEST_ENV which is required by conditional opensearch document setup #338

wants to merge 2 commits into from

Conversation

weilu
Copy link
Contributor

@weilu weilu commented Apr 3, 2025

Also minor fix for README instruction json file path

@weilu weilu requested a review from delcroip April 3, 2025 20:52
@weilu weilu mentioned this pull request Apr 3, 2025
Open
@delcroip
Copy link
Member

@weilu is the variable name important ? (in // I added IS_TESTING with the same definition)

@weilu
Copy link
Contributor Author

weilu commented Apr 18, 2025 •
edited
Loading

@weilu is the variable name important ? (in // I added IS_TESTING with the same definition)

@delcroip Where did you add IS_TESTING?

@weilu
Copy link
Contributor Author

weilu commented Apr 18, 2025

@delcroip the var name is important because it's already used by existing modules, for example: https://github.com/openimis/openimis-be-individual_py/blob/develop/individual/documents.py#L4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delcroip delcroip Awaiting requested review from delcroip

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weilu @delcroip