OP-1802 Add index on familly and insuree fields to improve database performance #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Feb 5, 2024
| ), | ||
| migrations.AddIndex( | ||
| model_name='insuree', | ||
| index=models.Index(fields=['legacy_id', 'validity_from', 'validity_to', 'chf_id'], name='tblInsuree_LegacyI_6f5da6_idx'), |
There was a problem hiding this comment.
Multicolumn indexes should be used sparingly. In most situations, an index on a single column is sufficient and saves space and time. Indexes with more than three columns are unlikely to be helpful unless the usage of the table is extremely stylized.
From PSQL docs: https://www.postgresql.org/docs/current/indexes-multicolumn.html
I know that not every implementation uses psql, but that code will work for everyone so it is worth considering if that many indexes are needed or wanted.
Member
There was a problem hiding this comment.
A few comments from me:
- I don't see a necessity to add validity_from in the index column.
- Add some columns on leaf level. That will help increase the performance.
- Give a proper name like IX_tblName_ColumnName
- Provide the fill factor (something like 80)
hirensoni913
reviewed
Mar 1, 2024
| ), | ||
| migrations.AddIndex( | ||
| model_name='insuree', | ||
| index=models.Index(fields=['legacy_id', 'validity_from', 'validity_to', 'chf_id'], name='tblInsuree_LegacyI_6f5da6_idx'), |
Member
There was a problem hiding this comment.
A few comments from me:
- I don't see a necessity to add validity_from in the index column.
- Add some columns on leaf level. That will help increase the performance.
- Give a proper name like IX_tblName_ColumnName
- Provide the fill factor (something like 80)
| managed = True | ||
| db_table = 'tblFamilies' | ||
| indexes = [ | ||
| models.Index(fields=['legacy_id', 'validity_from', 'validity_to']) |
| db_table = 'tblInsuree' | ||
| indexes = [ | ||
| models.Index(fields=['legacy_id', 'validity_from', 'validity_to', 'chf_id']) | ||
| ] |
Member
There was a problem hiding this comment.
Refer to my previous comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.