Skip to content

RTAB add mshr/directory grant mask#124

Merged
cfuguet merged 4 commits intoopenhwgroup:masterfrom
shaoqian2001:rtab-update-2
Mar 11, 2026
Merged

RTAB add mshr/directory grant mask#124
cfuguet merged 4 commits intoopenhwgroup:masterfrom
shaoqian2001:rtab-update-2

Conversation

@shaoqian2001
Copy link
Contributor

Use two round robin arbiters to grant replay requests that depend on MSHR entry and directory entry.

@shaoqian2001 shaoqian2001 requested a review from cfuguet as a code owner January 13, 2026 18:27
@cfuguet
Copy link
Contributor

cfuguet commented Jan 17, 2026

@shaoqian2001 Thank you very much for this PR. I will take a look ASAP.

@cfuguet cfuguet self-assigned this Jan 18, 2026
@cfuguet
Copy link
Contributor

cfuguet commented Feb 16, 2026

Hi @shaoqian2001,

I've just ran some long non-regression tests and everything is ok.

I do not see any performance improvement (or slowdown) though with RANDOM test sequences. But I expect to see some improvement in some specific benchmarks. Anyway, I think this should be merged.

Before I can merge, you need to sign the Eclipse Contributor Agreement. For this you need to create an Eclipse account. Normally, if you click on the failing check above (eclipsefdn/eca), you have the instructions to follow.

Can you please do this ?

Thanks !

César

@cfuguet cfuguet merged commit 308a272 into openhwgroup:master Mar 11, 2026
17 checks passed
@cfuguet
Copy link
Contributor

cfuguet commented Mar 11, 2026

Thanks @shaoqian2001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants