RTAB add mshr/directory grant mask#124
Merged
cfuguet merged 4 commits intoopenhwgroup:masterfrom Mar 11, 2026
Merged
Conversation
Contributor
|
@shaoqian2001 Thank you very much for this PR. I will take a look ASAP. |
Contributor
|
Hi @shaoqian2001, I've just ran some long non-regression tests and everything is ok. I do not see any performance improvement (or slowdown) though with RANDOM test sequences. But I expect to see some improvement in some specific benchmarks. Anyway, I think this should be merged. Before I can merge, you need to sign the Eclipse Contributor Agreement. For this you need to create an Eclipse account. Normally, if you click on the failing check above (eclipsefdn/eca), you have the instructions to follow. Can you please do this ? Thanks ! César |
Contributor
|
Thanks @shaoqian2001 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use two round robin arbiters to grant replay requests that depend on MSHR entry and directory entry.