Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(wip): add resource service unit tests and refactor helpers #768

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

test(wip): add resource service unit tests and refactor helpers #768

wants to merge 5 commits into from
+324 −52

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Oct 11, 2024 •
edited
Loading

Solution

This PR introduces comprehensive unit tests for the resource service module and refactors some existing code.

Breaking Changes

  • No - this PR is backwards compatible

Features:

  • Added new unit tests for getSiteResourceById, getFullPageById, and getPageById functions in the resource service

Improvements:

  • Removed unused getPages and getFolders functions from resource service
  • Refactored user creation helper functions for better reusability

Bug Fixes:

  • N/A

Tests

should pass

@vercel Vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 11:15am

This was referenced Oct 11, 2024
Merged
Merged
Merged
Draft
@karrui Graphite App
Copy link
Contributor Author

karrui commented Oct 11, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @karrui and the rest of your teammates on Graphite Graphite

@karrui karrui changed the title feat(resource.service): remove unused functions test: add resource service unit tests and refactor helpers Oct 11, 2024
@karrui karrui changed the title test: add resource service unit tests and refactor helpers test(wip): add resource service unit tests and refactor helpers Oct 11, 2024
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Oct 11, 2024 •
edited
Loading

Datadog Report

Branch report: resource_service_tests
Commit report: bb2a650
Test service: isomer-studio

✅ 0 Failed, 144 Passed, 23 Skipped, 34.39s Total Time
⬆️ Test Sessions change in coverage: 1 increased (+0.07%)

@karrui karrui force-pushed the resource_router_tests branch 2 times, most recently from d81f89e to dcfaa42 Compare October 11, 2024 09:48
@karrui karrui force-pushed the resource_service_tests branch from 0f943ae to afcfbf3 Compare October 11, 2024 09:49
@karrui karrui force-pushed the resource_router_tests branch from dcfaa42 to b03df30 Compare October 11, 2024 10:10
@karrui karrui force-pushed the resource_service_tests branch from afcfbf3 to 56c48fa Compare October 11, 2024 10:10
Base automatically changed from resource_router_tests to main October 11, 2024 10:17
@karrui karrui force-pushed the resource_service_tests branch from 56c48fa to 5cdec2c Compare October 11, 2024 10:18
@mergify Mergify
Copy link

mergify bot commented Nov 10, 2024

This pull request has been stale for more than 30 days! Could someone please take a look at it @opengovsg/isomer-engineers

@mergify mergify bot requested a review from a team November 10, 2024 10:19
@mergify Mergify
Copy link

mergify bot commented Dec 10, 2024

This pull request has been stale for more than 30 days! Could someone please take a look at it @opengovsg/isomer-engineers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karrui