🔧(tray) fix ineffective timeout settings for peertube runner requests #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous increases to connection timeouts had no effect due to the requests being proxied through proxy_to_marsha_app, which overrides those settings. This fix moves the timeout configuration directly into the `proxy_to_marsha_app` location block to ensure they are properly applied. Note: This is a temporary, hacky workaround to avoid 504 Gateway Timeouts when the PeerTube runner POSTs to /success. A proper fix is still needed.
kernicPanel
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previous increases to connection timeouts had no effect due to the requests being proxied through
proxy_to_marsha_app, which overrides those settings.This fix moves the timeout configuration directly into the
proxy_to_marsha_applocation block to ensure they are properly applied.Note: This is a temporary, hacky workaround to avoid 504 Gateway Timeouts when the PeerTube runner POSTs to /success. A proper fix is still needed.