Admin updates can trigger new backorders until the order cycle is closed #13065
Conversation
Admins may want to pre-process some orders manually for going public. And it's good to reserve stock for these. At some point in the future, the supplier may have an order cycle with its own times but the current FDC implementation allows orders at any time.
mkllnk
added
the
user facing changes
|
I'm away at orfc, so won't ba able to test this till next week. I'm also a bit confused @mkllnk - I thought you said (in the issue) we couldn't create a new back order when the order cycle is closed. 😕 did you figure out a way to track the order number? |
Okay, maybe we can test it then.
There's no technical limitation in creating backorders. And this pull request only creates backorders for order cycles before they close. After they close, we can assume that a backorder was placed and completed and then we shouldn't create a second one. But before the close time, it's okay. |
Actually, next week is fine. We won't have complete code review until next week either. |
| @@ -28,7 +28,7 @@ def amend_backorder(order) | |||
|
|
|||
| backorder = orderer.find_open_order(order) | |||
|
|
|||
| update(backorder, user, distributor, order_cycle) | |||
| update(backorder, user, distributor, order_cycle) if backorder | |||
There was a problem hiding this comment.
I guess it amounts to the same thing, but I thought that we usually avoid implied booleans and use the more explicit present?
But i'm sure it amounts to the same thing, and this looks cleaner so I like it :)
|
|
||
| expect(backorder.lines[0].quantity).to eq 1 # beans | ||
| expect(backorder.lines[1].quantity).to eq 5 # chia | ||
| end |
There was a problem hiding this comment.
Nice work, that's a tricky one to test. I guess the only other way would be to use VCR.
|
So I tested this & got an error email (Back Order failed) when I submitted an Order (via the admin interface) after OC close. I thought that wasn't supposed to happen now? 😕 |
Argh! I was so focused on the amending part that I forgot that the old initial backorder method is called whenever an order is finalised. I can add a check there or maybe make sure that it's only called during customer-facing checkout. |
When an admin creates an order, then AmendBackorderJob is called which can also trigger a new backorder if needed. This means that we are not creating backorders via subscriptions any more. It has never been requested and we can bring that back if needed.
mkllnk
force-pushed
the
dfc-amend-nothing
branch
from
44b797b to
c9eed4f
Compare
mkllnk
added
pr-staged-uk
|
@mkllnk - I started testing this... got a NoMethodError on the BackOrder job (which I started manually through sidekiq). I think it's related to removing a Product (Dulse flakes) from the Shopify DFC app before OC completion (long story, wasn't intentional on my part 🙄 ). It would be good if we could handle that more gracefully (users being what they are 🤨 ). Could we include in the error handling issue? Also happy to put it in a separate issue & prioritise (medium/low) Anyway, The admin interface still shows Test OC 24 as Open, so not sure I can validly test this. 😕 |
mkllnk
added
pr-staged-uk
|
Hm, I fixed that Bugsnag issue but now I just get a server error 500 from the Shopify API. Going through the OFN orders I think that the Shopify order would be adjusted to just one case of Balsamic which should be a valid order. I don't know why it fails. |
|
Digging into the stack trace it looks like I get the error when trying to retrieve the catalog. Maybe the token is expired? Oh, David was testing yesterday... I tried reconnecting but I wonder if the Shopify app is missing a valid token. Is that something I can check myself? A 500 error is really not great there either. |
What? Why?
We had a case when an order was updated after the order cycle closed. The backorder amendment failed because the backorder was completed already. We now handle this gracefully by skipping the amendment. But if the order cycle is still open or will open then we can actually create a new backorder. We can assume that the order cycle hasn't had a backorder yet.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates