Add 'Voucher:' before voucher code on edit cart page

[kernal053]

What? Why?

• Closes Add 'Voucher:' before voucher code on edit cart page #13059

What should we test?

• When voucher is used in an order as a shopper, edit cart page will contain "Voucher:" text before voucher code.
• Check also for translated "Voucher" text.

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

Before:

After:

[drummer83]

Thank you, @kernal053! That was super fast!

Is it ready for review?

[kernal053]

Is it ready for review?

Yes.

[drummer83]

Great! I wonder if it makes sense to use the same string as we do in other places. That way at least those ones where we want the format 'Voucher: Code' are always the same.
See app/views/checkout/summary.html.haml.

What do you think? Does it make sense, @kernal053?

[kernal053]

Yes, it makes sense to ensure consistent format.

So, should I go ahead and make similar changes inapp/views/checkout/_summary.html.haml& app/views/spree/orders/_totals_footer.html.haml(for order confirmation page) witht(:order_voucher_label, code: adjustment.label)format ?

[drummer83]

I was thinking the other way round? 🤔

[rioug]

Looks like there is more work to be done here, and also could you address the rubocop warning ? Moving back to in process.

[kernal053]

I was thinking the other way round? 🤔

@drummer83 Apologies, I thought it will provide flexibility for customizing format if needed in future with just changing scope in en.yml such as Voucher (CODE), CODE (Voucher) ?

If we're planning to keep format 'Voucher: Code' then I will change it to same string as we are using in other places currently.

[drummer83]

If we're planning to keep format 'Voucher: Code' then I will change it to same string as we are using in other places currently.

Yes, let's keep the format because the positions above and below have the same format and they are hard coded as well.

Thanks again, especially for your patience, and sorry for the confusion.

[dacook]

Good fix, and great work on the specs, thank you!

I like the idea of using the translation engine as you suggested, but it's good that this is consistent with other parts of the app 👍

[mkllnk]

Thank you.

[filipefurtad0]

Hey @kernal053 ,

Thanks for this improvement!

I was able to verify the change you've introduced:

Before this PR

After this PR

This closes the underlying issue and can be merged.
Thanks again 🎉