Fix DFC catalog syncs for blank cart

[chahmedejaz]

ℹ️ Funded Feature. Please track ALL ASSOCIATED WORK under the associated tracking code #11678 DFC Orders

What? Why?

• Closes DFC catalog syncs for blank cart #13024

What should we test?

• In an order cycle with DFC products:
• Check that stock adjusts after changes in Shopify after the user added a product to the cart.
• If an item goes out of stock during checkout, the checkout should fail.

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

[mkllnk]

Nice! I fixed one little typo but otherwise it's all good.

I always try to avoid send but it's the most pragmatic way here to avoid code duplication.

[dacook]

Looks good to me 👍

[dacook]

I always try to avoid send but it's the most pragmatic way here to avoid code duplication.

I was thinking the same, but it's good to see deduplication.

Another way I could think of was to use a block, but it's not really worth it in this case.
Just to refresh myself on blocks, I thought I'd see how it looks:

def sync_catalogs(order)
  ...
  catalog_ids(order).each do |catalog_id|
     yield(user, catalog_id)
  end
 ...
end

def self.sync_linked_catalogs_later(order)
  sync_catalogs do |user, catalog_id|
    perform_later(user, catalog_id)
  end
end

.. err no, definitely not worth it!

[dacook]

@mkllnk can you comment if the testing team able is able to test this, or should it go to Garethe?

[mkllnk]

I think it's quickest if I test.

[mkllnk]

The FDC Shopify API servers are shut down at the moment to save cost. Garethe will power them up again soon.

[RaggedStaff]

The FDC Shopify API servers are shut down at the moment to save cost. Garethe will power them up again soon.

@mkllnk - they're back up now.

[mkllnk]

All works beautifully. Well done.