Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade updates #964

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Upgrade updates #964

merged 2 commits into from
Nov 21, 2024

Conversation

dacook
Copy link
Member

@dacook dacook commented Nov 20, 2024

Is it ok not to have netdev group?

An image of Ubuntu didn't have this group (Ubuntu 20.04.6 LTS (GNU/Linux 5.4.0-196-generic x86_64))
Dunno why. Maybe we don't need it?
@dacook dacook self-assigned this Nov 20, 2024
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -2,7 +2,7 @@
- name: create deploy user
user:
name="{{ user }}"
groups=adm,dialout,cdrom,floppy,audio,dip,video,plugdev,netdev,sudo
groups=adm,dialout,cdrom,floppy,audio,dip,video,plugdev,sudo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally fine. We have sudo for everything we want to do.

@mkllnk mkllnk merged commit 1980182 into openfoodfoundation:master Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants