-
Notifications
You must be signed in to change notification settings - Fork 14
chore: update example to work with latest changes to type enums and liststores #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes update the example application to use OpenFga SDK version 0.8.0, incorporating breaking API changes including a modified ListStores method signature that now requires a ClientListStoresRequest parameter and enum member renames for TypeName constants. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates Example1 to be compatible with SDK version 0.8.0 by addressing breaking changes introduced in versions 0.6.0 and 0.7.0. The changes fix compilation errors related to the ListStores API signature changes and TypeName enum value updates.
Key changes:
- Updated SDK dependency from version 0.5.1 to 0.8.0
- Modified
ListStorescalls to accept aClientListStoresRequestparameter (breaking change from v0.6.0) - Updated
TypeNameenum values to use new naming convention (breaking change from v0.7.0)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| example/Example1/Example1.csproj | Updated OpenFga.Sdk package reference from version 0.5.1 to 0.8.0 |
| example/Example1/Example1.cs | Updated ListStores API calls to pass ClientListStoresRequest parameter and updated TypeName enum values to match v0.7.0 naming convention (INT → TYPENAMEINT, STRING → TYPENAMESTRING) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SoulPancake
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Description
What problem is being solved?
Currently the example has the following errors when being ran against a newer version of the SDK.
What changes are made to solve it?
Updated referenced SDK to latest and make required changes.
References
Review Checklist
mainSummary by CodeRabbit
New Features
Chores