This repository has been archived by the owner on Mar 7, 2020. It is now read-only.
Update handler.py #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add link to Patreon page within the thank you tweet Fixes #8 Signed-off-by: Sal DiStefano <[email protected]>
ghost
closed this
alexellis
reviewed
Jan 12, 2019
|
With the added link to the Patreon site, using the last tweet as an estimate, it was only at 122 characters. As of last year, Twitter allows 280 characters per Tweet, so I think we're ok. We could always check the length of the Tweet string and validate before trying to send, and modify if necessary. |
|
ping @alexellis to merge this. |
|
Let's please validate before we add the final part of the URL. |
|
Having a clear-up on GitHub issues / PRs over 1 month old. Let's revisit as necessary. Thank you for the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add link to Patreon page within the thank you tweet
Fixes #8
Signed-off-by: Sal DiStefano [email protected]