-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i18n): translate files and videos table view #1591
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @igobranco! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
96f091a
to
80b66ec
Compare
80b66ec
to
8dba735
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1591 +/- ##
==========================================
+ Coverage 93.07% 93.24% +0.17%
==========================================
Files 1092 1100 +8
Lines 21617 21795 +178
Branches 4577 4703 +126
==========================================
+ Hits 20120 20323 +203
+ Misses 1431 1400 -31
- Partials 66 72 +6 ☔ View full report in Codecov by Sentry. |
This is ready for review, @openedx/2u-tnl. Thanks! |
Description
Fix translation issue on Files and Videos table view mode on the columns.
Screen capture From Open edX Sandbox.
URL: https://apps.sandbox.openedx.org/course-authoring/course/course-v1:OpenedX+IS+2025_T1/assets:
English:
Portuguese (Portugal) pt-pt locale, the table header isn't translated:
With this fix:
Testing instructions
Need to pull translations, example just for pt_PT locale.
make OPENEDX_ATLAS_PULL=true ATLAS_OPTIONS="--filter=pt_PT" pull_translations
Append the new translations on for example for pt_PT locale (file: src/i18n/messages/frontend-app-course-authoring/pt_PT.json):
Then view the course authoring MFE using that other locale. Example change
openedx-language-preference
cookie value on your browser topt-pt
.