Skip to content

fix: use geom_type instead of type for Shapely objects #36699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dwong2708
Copy link

@dwong2708 dwong2708 commented May 9, 2025

Description

Fixes: #35176, #35044

These changes update references to Shapely's type property to use geom_type instead, due to deprecation warnings.

Useful information to include:

Here is the evidence of the deprecation warning message:

Before:
image

After:
image

Additionally. The helper called test_capa_system was updated by get_capa_system. The reason is pytest was taken this function as a test but actually is a helper.

Here the evidence of the deprecation message:

image

After the fix:

image

Supporting information

This PR addresses the following ticket: #35176

Testing instructions

Simply run this test: pytest xmodule xmodule/capa/tests/test_responsetypes.py

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 9, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented May 9, 2025

Thanks for the pull request, @dwong2708!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions May 9, 2025
@dwong2708 dwong2708 marked this pull request as ready for review May 9, 2025 21:30
@dwong2708 dwong2708 requested review from feanil and irtazaakram May 9, 2025 21:31
@dwong2708 dwong2708 force-pushed the fix-depr-warnings branch from cfc7798 to dc20942 Compare May 9, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: The 'type' attribute is deprecated in Shapely.
2 participants