refactor: Use derive_settings to lazy load settings.
#36205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
|
@feanil , this PR is ready as well. It is identical to your version of the PR, except:
|
Some of our settings depend on the values of other settings. Rather than explicitly looking up each one in the YAML settings file, we can simply derive them based on the setting in the YAML file after all the YAML settings have been loaded. Co-Authored-By: Feanil Patel <[email protected]>
kdmccormick
force-pushed
the
kdmccormick/use-derived-tooling
branch
from
82a57f3 to
fc1a6f5
Compare
|
I have successfully verified this using dump_settings with both Tutor's yamls and the redacted prodlike yamls. FYI @dianakhuang . |
feanil
approved these changes
Feb 4, 2025
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of our settings depend on the values of other settings. Rather
than explicitly looking up each one in the YAML settings file, we can
simply derive them based on the setting in the YAML file after all the
YAML settings have been loaded.
Supporting information
Originally authored by @feanil here:
derived_settingsto lazy load settings. #36124BLOCKED by this derived_settings API improvement:
Part of:
Testing information
Same as #36192, but diff using this PR's branch.