-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor country disable logic into the Embargo app #36202
base: master
Are you sure you want to change the base?
feat: refactor country disable logic into the Embargo app #36202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this PR correspond to a specific scope of work? Could you populate the PR description to explain the purpose and implementations?
b786611
to
682e58e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me.
Description
This PR refactors the existing implementation of DISABLED_COUNTRIES, which previously controlled country visibility in the Legacy registration form and restrict users from switching to disabled countries. Validation errors were implemented separately in Authn MFE and Account MFE due to their different country listing mechanisms. The new approach moves the disabled countries logic from environment settings to a database-driven model within the Embargo Django App. As part of this refactor, the DISABLED_COUNTRIES setting will be deprecated, and all related functionality will be transitioned to the new model-based system.
Related links
Internal 2U Ticket: https://2u-internal.atlassian.net/browse/INF-1760
Testing instructions