chore: parse all arguments together

Signed-off-by: Prateek Chandra <[email protected]>

Author: pchandra19

scripts/staging/validate.sh

@@ -3,8 +3,10 @@ set -euo pipefail
 
 # --- Default Variables ---
 CHART_VALIDATE="false"
+TRIGGER=""
+TAG=""
 
-# --- Parse arguments early so CHART_VALIDATE is set before using it ---
+# --- Parse arguments --- 
 for ((i=1; i <= $#; i++)); do
   case "${!i}" in
     --chart)
@@ -16,6 +18,28 @@ for ((i=1; i <= $#; i++)); do
   esac
 done
 
+while [[ $# -gt 0 ]]; do
+    case $1 in
+        --trigger|--type)
+            TRIGGER="$2"; shift 2 ;;
+        --tag)
+            TAG="$2"; shift 2 ;;
+        --chart)
+            CHART_VALIDATE="$2"; shift 2 ;;
+        -h|--help)
+            cat <<EOF
+Usage: $0 --trigger <trigger> [--tag <tag>] [--chart <true|false>]
+Options:
+  --trigger <type>        release, staging, develop, prerelease
+  --type <type>           Alias for --trigger
+  --tag <tag>             Release tag (e.g., v2.9.0)
+  --chart <true|false>    Enable or disable Helm chart validation (default: false)
+EOF
+            exit 0 ;;
+        *) log_fatal "Unknown option $1" ;;
+    esac
+done
+
 # --- Determine paths based on CHART_VALIDATE ---
 SCRIPT_DIR="$(dirname "$(realpath "${BASH_SOURCE[0]:-"$0"}")")"
 source "${SCRIPT_DIR}/../utils/log.sh"
@@ -48,31 +72,7 @@ INDEX_BRANCH="${INDEX_BRANCH:-gh-pages}"
 INDEX_BRANCH_FILE="${INDEX_BRANCH_FILE:-index.yaml}"
 CHART_FILE="${CHART_FILE:-${PARENT_ROOT_DIR}/charts/Chart.yaml}"
 
-TRIGGER=""
-TAG=""
 
-# --- Parse remaining args properly ---
-while [[ $# -gt 0 ]]; do
-    case $1 in
-        --trigger|--type)
-            TRIGGER="$2"; shift 2 ;;
-        --tag)
-            TAG="$2"; shift 2 ;;
-        --chart)
-            CHART_VALIDATE="$2"; shift 2 ;;
-        -h|--help)
-            cat <<EOF
-Usage: $0 --trigger <trigger> [--tag <tag>] [--chart <true|false>]
-Options:
-  --trigger <type>        release, staging, develop, prerelease
-  --type <type>           Alias for --trigger
-  --tag <tag>             Release tag (e.g., v2.9.0)
-  --chart <true|false>    Enable or disable Helm chart validation (default: false)
-EOF
-            exit 0 ;;
-        *) log_fatal "Unknown option $1" ;;
-    esac
-done
 
 # --- Validations ---
 echo "Validating trigger: $TRIGGER"