chore: make user and password optional

Signed-off-by: Prateek Chandra <[email protected]>

Author: pchandra19

scripts/staging/kubectl-oci.sh

@@ -2,14 +2,15 @@
 # Manage kubectl plugin binaries as OCI artifacts.
 # Supports both pushing and pulling operations.
 # Usage:
-#   Push: ./kubectl-oci.sh push --tag <tag> --namespace <namespace> --username <user> --password <token>
-#   Pull: ./kubectl-oci.sh pull --tag <tag> --namespace <namespace> --username <user> --password <token>
+#   Push: ./kubectl-oci.sh push --tag <tag> --namespace <namespace> [--username <user> --password <token>]
+#   Pull: ./kubectl-oci.sh pull --tag <tag> --namespace <namespace> [--username <user> --password <token>]
 
 set -euo pipefail
 
 SCRIPT_DIR="$(dirname "$(realpath "${BASH_SOURCE[0]:-"$0"}")")"
 ROOT_DIR="$SCRIPT_DIR/../"
 
+# shellcheck source=../utils/log.sh
 source "$ROOT_DIR/utils/log.sh"
 
 ACTION=""
@@ -19,6 +20,7 @@ USERNAME=""
 PASSWORD=""
 REGISTRY="ghcr.io"
 PLUGIN="${PLUGIN:-"mayastor"}"
+NO_LOGIN=false
 
 usage() {
   cat << EOF
@@ -32,12 +34,14 @@ Options:
   --tag <tag>             Release tag (required)
   --registry <registry>   The registry to push/pull from [default=$REGISTRY]
   --namespace <namespace> Namespace path (required)
-  --username <username>   Registry username (required)
-  --password <password>   Registry token/password (required)
+  --username <username>   Registry username (optional if already logged in)
+  --password <password>   Registry token/password (optional if already logged in)
+  --no-login              Skip login check (useful for CI/CD with pre-auth)
+  -h, --help              Show this help message
 
 Examples:
   $0 push --tag v1.0.0 --namespace $PLUGIN/dev --username user --password token
-  $0 pull --tag v1.0.0 --namespace $PLUGIN/dev --username user --password token
+  $0 pull --tag v1.0.0 --namespace $PLUGIN/dev
 EOF
 }
 
@@ -81,6 +85,10 @@ parse_args() {
         PASSWORD="$2"
         shift 2
         ;;
+      --no-login)
+        NO_LOGIN=true
+        shift
+        ;;
       -h|--help)
         usage
         exit 0
@@ -92,16 +100,31 @@ parse_args() {
     esac
   done
 
-  if [[ -z "$TAG" ]] || [[ -z "$NAMESPACE" ]] || [[ -z "$USERNAME" ]] || [[ -z "$PASSWORD" ]]; then
+  if [[ -z "$TAG" ]] || [[ -z "$NAMESPACE" ]]; then
     usage
-    log_fatal "Error: All options (--tag, --namespace, --username, --password) are required"
+    log_fatal "Error: --tag and --namespace are required"
+  fi
+
+  if [[ -z "${USERNAME:-}" || -z "${PASSWORD:-}" ]]; then
+    echo "⚠️  No username/password provided — will attempt to use existing oras login session for ${REGISTRY}"
   fi
 
-  REPOSITORY=${REGISTRY}/${NAMESPACE}/kubectl-${PLUGIN}
+  REPOSITORY="${REGISTRY}/${NAMESPACE}/kubectl-${PLUGIN}"
 }
 
-# Login to registry
+# Login to registry (only if needed)
 login_registry() {
+  echo "Checking login status for ${REGISTRY}..."
+
+  if oras login "${REGISTRY}" --get >/dev/null 2>&1; then
+    echo "Already logged in to ${REGISTRY}"
+    return 0
+  fi
+
+  if [[ -z "${USERNAME:-}" || -z "${PASSWORD:-}" ]]; then
+    log_fatal "Error: Not logged in to ${REGISTRY} and no credentials provided. Use --username and --password."
+  fi
+
   echo "Logging in to ${REGISTRY}..."
   echo "${PASSWORD}" | oras login "${REGISTRY}" --username "${USERNAME}" --password-stdin
 }
@@ -129,7 +152,7 @@ push_artifacts() {
 
   rm -f "${combined_tar}"
 
-  echo "✓ All kubectl binaries pushed successfully as a single bundle!"
+  echo "All kubectl binaries pushed successfully as a single bundle!"
   echo "Bundle available at: ${REPOSITORY}:${TAG}"
 }
 
@@ -155,12 +178,15 @@ pull_artifacts() {
   echo "Contents of artifacts directory after extraction:"
   ls -la artifacts/
 
-  echo "✓ All kubectl binaries pulled successfully!"
+  echo "All kubectl binaries pulled successfully!"
 }
 
 main() {
   parse_args "$@"
-  login_registry
+
+  if [[ "$NO_LOGIN" == false ]]; then
+    login_registry
+  fi
 
   case "$ACTION" in
     push)

scripts/staging/validate.sh

@@ -18,17 +18,14 @@ done
 
 # --- Determine paths based on CHART_VALIDATE ---
 SCRIPT_DIR="$(dirname "$(realpath "${BASH_SOURCE[0]:-"$0"}")")"
+source "${SCRIPT_DIR}/../utils/log.sh"
 
 if [[ "${CHART_VALIDATE}" == "true" ]]; then
     ROOT_DIR="${SCRIPT_DIR}/../../../../../../"
     : "${PARENT_ROOT_DIR:=$ROOT_DIR}"
-
-    source "$ROOT_DIR/dependencies/control-plane/utils/dependencies/scripts/utils/log.sh"
 else
     ROOT_DIR="${SCRIPT_DIR}/../../../../"
     : "${PARENT_ROOT_DIR:=$ROOT_DIR}"
-
-    source "$ROOT_DIR/utils/dependencies/scripts/utils/log.sh"
 fi
 
 # --- Run release.sh in a subshell ---