This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Local uri input monitor support - #250
Open
AWSHurneyt wants to merge 5 commits into
opendistro-for-elasticsearch:local-uri-input-monitor-supportfrom
AWSHurneyt:local-uri-input-monitor-support
Open
Local uri input monitor support#250AWSHurneyt wants to merge 5 commits intoopendistro-for-elasticsearch:local-uri-input-monitor-supportfrom AWSHurneyt:local-uri-input-monitor-support
AWSHurneyt wants to merge 5 commits into
opendistro-for-elasticsearch:local-uri-input-monitor-supportfrom
AWSHurneyt:local-uri-input-monitor-support
Conversation
AWSHurneyt
requested review from
annie3431,
lezzago,
rishabhmaurya,
skkosuri-amzn and
tlfeng
April 7, 2021 03:43
tlfeng
reviewed
Apr 19, 2021
tlfeng
left a comment
Contributor
There was a problem hiding this comment.
Overall, look's good and clean. 👍
…ments, and refactored help text based on PR feedback.
tlfeng
approved these changes
Apr 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 166
Description of changes:
This PR is inherited from #166.
Implementations are adapted from #166 for use with
LocalUriInput.Internal Changes
HttpInputtoLocalUriInputto reflect that this feature only supports local clusters at this time. Only apathfield has been exposed ashostandportonly supportlocalhostand9200for now.create monitor,edit monitor, andcreate triggerpages display properly forLocalUriInputtype monitors.formikToMonitor.jsto handleLocalUriInputtype monitors.LocalUriInput.test.jssnapshot test.formikToInputs()andformikToLocalUri()informikToMonitor.test.js.can build LocalUriInput monitortest tomonitorToFormik.test.js.External Changes
getOverviewStatsto displayLocal URIdefinition type.Responseblock on the create monitor page will display the response contents for the API called using the providedpath.CreateTrigger.jssuch that theTrigger Conditionblock on the create trigger page will display the first field name in the API response for LocalUriInput monitors (e.g.,ctx.results[0].XXX != null).UX Screenshots

Additional option in the 'define monitor' dropdown menuThe 'Create Monitor' pageThe 'Create Trigger' pageThe 'Monitor Overview' pageBy making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.