Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first Model Registry tests #54

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Add first Model Registry tests #54

wants to merge 16 commits into from

Conversation

lugi0
Copy link
Collaborator

@lugi0 lugi0 commented Dec 5, 2024

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@lugi0
Copy link
Collaborator Author

lugi0 commented Dec 6, 2024

Needs RedHatQE/openshift-python-wrapper#2220 to be merged first

@lugi0 lugi0 marked this pull request as ready for review December 6, 2024 15:13
@lugi0 lugi0 requested review from rnetser and adolfo-ab December 6, 2024 15:13
@tarukumar
Copy link
Contributor

overall looks good. Add small comment

adolfo-ab
adolfo-ab reviewed Dec 10, 2024
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
tests/model_registry/conftest.py Outdated Show resolved Hide resolved
tests/model_registry/test_model_registry_creation.py Outdated Show resolved Hide resolved
tests/model_registry/utils.py Show resolved Hide resolved
tests/model_registry/utils.py Outdated Show resolved Hide resolved
tests/model_registry/utils.py Outdated Show resolved Hide resolved
@lugi0 lugi0 requested review from tarukumar and adolfo-ab December 10, 2024 15:51
adolfo-ab
adolfo-ab previously approved these changes Dec 11, 2024
View reviewed changes
tarukumar
tarukumar previously approved these changes Dec 11, 2024
View reviewed changes
@lugi0 lugi0 dismissed stale reviews from tarukumar and adolfo-ab via 7728bb4 December 11, 2024 15:19
@lugi0 lugi0 requested review from tarukumar and adolfo-ab December 12, 2024 09:22
rnetser
rnetser requested changes Dec 12, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests/model_registry/conftest.py Show resolved Hide resolved
tests/model_registry/conftest.py Show resolved Hide resolved
tests/model_registry/conftest.py Outdated Show resolved Hide resolved
tests/model_registry/test_rest_api.py Show resolved Hide resolved
tests/model_registry/test_rest_api.py Outdated Show resolved Hide resolved
tests/model_registry/utils.py Show resolved Hide resolved
tests/model_registry/utils.py Outdated Show resolved Hide resolved
utilities/constants.py Outdated Show resolved Hide resolved
@lugi0
Address comments
0f32392 
Signed-off-by: lugi0 <[email protected]>
@lugi0 lugi0 requested a review from rnetser December 12, 2024 12:05
rnetser
rnetser requested changes Dec 15, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests/model_registry/conftest.py Outdated Show resolved Hide resolved
tests/model_registry/conftest.py Outdated Show resolved Hide resolved
tests/model_registry/conftest.py Outdated Show resolved Hide resolved
tests/model_registry/test_model_registry_creation.py Outdated Show resolved Hide resolved
tests/model_registry/test_model_registry_creation.py Outdated Show resolved Hide resolved
tests/model_registry/utils.py Show resolved Hide resolved
rnetser
rnetser reviewed Dec 15, 2024
View reviewed changes
utilities/constants.py Outdated Show resolved Hide resolved
rnetser
rnetser requested changes Dec 15, 2024
View reviewed changes
tests/model_registry/utils.py Outdated Show resolved Hide resolved
tests/model_registry/utils.py Outdated Show resolved Hide resolved
@lugi0 lugi0 requested a review from rnetser December 17, 2024 16:21
adolfo-ab
adolfo-ab previously approved these changes Dec 18, 2024
View reviewed changes
tarukumar
tarukumar previously approved these changes Dec 18, 2024
View reviewed changes
@lugi0
fix typing
afbe4ca 
Signed-off-by: lugi0 <[email protected]>
@lugi0 lugi0 dismissed stale reviews from tarukumar and adolfo-ab via afbe4ca December 19, 2024 08:57
@lugi0 lugi0 requested review from tarukumar and adolfo-ab December 19, 2024 08:58
@lugi0
Address comments
1f3229e 
Signed-off-by: lugi0 <[email protected]>
@lugi0 lugi0 self-assigned this Dec 20, 2024
@lugi0
Copy link
Collaborator Author

lugi0 commented Dec 20, 2024

Do not merge right now, still needs testing

rnetser
rnetser requested changes Dec 22, 2024
View reviewed changes
tests/trustyai/drift/test_drift.py
@@ -23,14 +23,14 @@ class TestDriftMetrics:
def test_send_inference_request_and_verify_trustyai_service(
self,
admin_client,
openshift_token,
current_client_token,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openshift_token should be deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnetser rnetser rnetser requested changes

@tarukumar tarukumar Awaiting requested review from tarukumar

@adolfo-ab adolfo-ab Awaiting requested review from adolfo-ab

Requested changes must be addressed to merge this pull request.

Assignees

@lugi0 lugi0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lugi0 @tarukumar @rnetser @adolfo-ab