feat(RHOAIENG-35050): add support to pass Garak KFP image for downstream

[ruivieira]

Description

This PR implements image replacement for the garak-provider-image parameter in the TrustyAI operator.
Related JIRAs and PRs:

• feat: Add new provider images for RhoAI configuration trustyai-explainability/trustyai-service-operator#565
• https://issues.redhat.com/browse/RHOAIENG-35050

(this PR supersedes #2567, which was closed)

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work
• The developer has run the integration test pipeline and verified that it passed successfully

E2E test suite update requirement

When bringing new changes to the operator code, such changes are by default required to be accompanied by extending and/or updating the E2E test suite accordingly.

To opt-out of this requirement:

1. Please inspect the opt-out guidelines, to determine if the nature of the PR changes allows for skipping this requirement
2. If opt-out is applicable, provide justification in the dedicated E2E update requirement opt-out justification section below
3. Check the checkbox below:

• Skip requirement to update E2E test suite for this PR

4. Submit/save these changes to the PR description. This will automatically trigger the check.

E2E update requirement opt-out justification

Small change

Summary by CodeRabbit

• New Features
  • TrustyAI now recognizes and supports the Garak provider image, expanding options for model evaluation and validation.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds a new image parameter mapping in the TrustyAI support module: the key "garak-provider-image" now maps to the environment variable "RELATED_IMAGE_ODH_TRUSTYAI_GARAK_LLS_PROVIDER_DSP_IMAGE".

Changes

Cohort / File(s)	Summary
TrustyAI image parameter mapping internal/controller/components/trustyai/trustyai_support.go	Adds map entry: "garak-provider-image" → "RELATED_IMAGE_ODH_TRUSTYAI_GARAK_LLS_PROVIDER_DSP_IMAGE"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A small key hops into the map,
RELATED_IMAGE set with a tap,
Garak's provider finds its name,
Quiet change, but all the same,
Hooray — a tidy tiny clap! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding support to pass the Garak KFP image for downstream in the TrustyAI operator component.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11da084 and 3732044.

📒 Files selected for processing (1)

• internal/controller/components/trustyai/trustyai_support.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build/push catalog image
• GitHub Check: Run tests and collect coverage on internal and pkg
• GitHub Check: golangci-lint

🔇 Additional comments (1)

internal/controller/components/trustyai/trustyai_support.go (1)

24-35: New garak-provider-image mapping requires wiring verification

The "garak-provider-image" → "RELATED_IMAGE_ODH_TRUSTYAI_GARAK_LLS_PROVIDER_DSP_IMAGE" entry follows the established naming pattern of the existing RAGAS provider mapping, with no syntax or structural issues in the map definition itself. However, confirm that both the key and environment variable are properly wired in kustomize overlays, patches, and CSV/release manifests. Verify the mapping is referenced in the same locations where the RAGAS provider image is configured.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign carlkyrillos for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ruivieira]

@zdtsw FYI this is a new PR to replace #2567, which was closed.

[zdtsw]

has this new image in place? i could not find it on rhoai 3.2 branch

[riprasad]

https://gitlab.cee.redhat.com/releng/konflux-release-data/-/blob/main/config/stone-prod-p02.hjvn.p1/product/ReleasePlanAdmission/rhoai/rhoai-onprem-v3-2-components-prod.yaml#L207-L208

IIRC, this image onboarding was deferred and @moulalis was working on it. However, based on the Image name odh-trustyai-garak-lls-provider-dsp-rhel9, The variable name should be RELATED_IMAGE_ODH_TRUSTYAI_GARAK_LLS_PROVIDER_DSP_IMAGE.

Also, @moulalis It will be nice if we can keep the component and the image name aligned. Component name should be odh-trustyai-garak-lls-provider-dsp-v3-2

[ruivieira]

@riprasad thanks, I'll update the variable here to keep it aligned with the image name. @moulalis I'll bring the conversation about the image status to an offline channel.

[ruivieira]

Variable name changed to RELATED_IMAGE_ODH_TRUSTYAI_GARAK_LLS_PROVIDER_DSP_IMAGE with 06c8c9d

[zdtsw]

once @riprasad can confirm downstream image is built and the name is correct, we can merge this PR

[zdtsw]

/LGTM

[openshift-ci]

@ruivieira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/opendatahub-operator-e2e	3732044	link	true	/test opendatahub-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.