update: add check on dashboard's acceleratorprofile

[zdtsw]

• if CRD does not exist e.g from 3.0, no need own it -- no error into Operator

Description

on current 3.0 build, operator flooded with error if running e2e:
{"level":"error","ts":"2025-11-11T10:51:56Z","logger":"controller-runtime.source.EventHandler","msg":"if kind is a CRD, it should be installed before calling Start","kind":"AcceleratorProfile.dashboard.opendatahub.io","error":"no matches for kind \"AcceleratorProfile\" in version \"dashboard.opendatahub.io/v1\"","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind[...]).Start.func1.1\n\t/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/source/kind.go:71\nk8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext.func2\n\t/opt/app-root/src/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/loop.go:87\nk8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext\n\t/opt/app-root/src/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/loop.go:88\nk8s.io/apimachinery/pkg/util/wait.PollUntilContextCancel\n\t/opt/app-root/src/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/poll.go:33\nsigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind[...]).Start.func1\n\t/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/source/kind.go:64"}

this change should be eventually go away from #2698 but since we have not dediced when we will do the final switch , this PR is just to make the log more clean and one less CRD for controller

How Has This Been Tested?

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work
• The developer has run the integration test pipeline and verified that it passed successfully

E2E test suite update requirement

When bringing new changes to the operator code, such changes are by default required to be accompanied by extending and/or updating the E2E test suite accordingly.

To opt-out of this requirement:

1. Please inspect the opt-out guidelines, to determine if the nature of the PR changes allows for skipping this requirement
2. If opt-out is applicable, provide justification in the dedicated E2E update requirement opt-out justification section below
3. Check the checkbox below:

• Skip requirement to update E2E test suite for this PR

4. Submit/save these changes to the PR description. This will automatically trigger the check.

E2E update requirement opt-out justification

depreacted logic in v3 but kept it for a short while

Summary by CodeRabbit

• Bug Fixes
  • Improved dashboard component stability by adding a configuration existence check. The system now gracefully handles scenarios where optional dashboard components are not available, preventing unnecessary resource watching and potential conflicts.

[coderabbitai]

Walkthrough

The dashboard component's watch for DashboardAcceleratorProfile is updated to include a CRD-existence guard. The OwnsGVK call now passes reconciler.Dynamic(reconciler.CrdExists(gvk.DashboardAcceleratorProfile)) instead of reconciler.Dynamic(), ensuring the controller only watches the CRD when it exists.

Changes

Cohort / File(s)	Change Summary
Dashboard Controller Guard internal/controller/components/dashboard/dashboard_controller.go	Modified OwnsGVK call for DashboardAcceleratorProfile to add CRD-existence guard via reconciler.CrdExists()

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

• Verify the guard placement is correct within the reconciler setup
• Confirm reconciler.CrdExists() is the appropriate guard function for this use case
• Ensure no other DashboardAcceleratorProfile watches need the same guard applied

Poem

🐰 A guard stands watch at the CRD's door,
No phantom shadows to worry anymore!
The profile now checks—does it exist, truly?
Before dancing the reconcile routine, dutifully! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly relates to the main change: adding a CRD-existence check for the dashboard's AcceleratorProfile in the controller.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.07%. Comparing base (6891bef) to head (2e67562).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...oller/components/dashboard/dashboard_controller.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2846   +/-   ##
=======================================
  Coverage   50.07%   50.07%           
=======================================
  Files         144      144           
  Lines       10469    10469           
=======================================
  Hits         5242     5242           
  Misses       4669     4669           
  Partials      558      558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlkyrillos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [carlkyrillos]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[carlkyrillos]

/cherrypick rhoai

[openshift-cherrypick-robot]

@carlkyrillos: new pull request created: #2849

In response to this:

/cherrypick rhoai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.