Add unit test coverage on the dashboard component

.gitignore

@@ -57,6 +57,12 @@ opt/manifests/
 
 cover.out
 
+# Coverage HTML reports
+*_coverage.html
+*_coverage.out
+coverage.html
+coverage.out
+overall_coverage.out
 config/manager/kustomization.yaml
 
 # Ignore any local.mk files that would be consumed by the Makefile
@@ -67,3 +73,6 @@ local.mk
 
 # Ignore catalog related files
 catalog/
+
+# Ignore backup files
+*.backup

Makefile

@@ -436,7 +436,18 @@ unit-test: envtest ginkgo # directly use ginkgo since the framework is not compa
         		--coverprofile=cover.out \
         		--succinct \
         		$(TEST_SRC)
-CLEANFILES += cover.out
+CLEANFILES += cover.out coverage.html
+
+.PHONY: test-coverage
+test-coverage: ## Generate HTML coverage report
+	$(MAKE) unit-test || true
+	@if [ ! -f cover.out ] || [ ! -s cover.out ]; then \
+		echo "Warning: cover.out is missing or empty. Skipping coverage report generation."; \
+		echo "Make sure unit tests are configured to generate coverage data."; \
+		exit 0; \
+	fi
+	go tool cover -html=cover.out -o coverage.html
+	@echo "Coverage report generated: coverage.html"
 
 $(PROMETHEUS_TEST_DIR)/%.rules.yaml: $(PROMETHEUS_TEST_DIR)/%.unit-tests.yaml $(PROMETHEUS_CONFIG_YAML) $(YQ)
 	$(YQ) eval ".data.\"$(@F:.rules.yaml=.rules)\"" $(PROMETHEUS_CONFIG_YAML) > $@

internal/controller/components/dashboard/dashboard.go

@@ -22,32 +22,32 @@ import (
 	"github.com/opendatahub-io/opendatahub-operator/v2/pkg/metadata/annotations"
 )
 
-type componentHandler struct{}
+type ComponentHandler struct{}
 
 func init() { //nolint:gochecknoinits
-	cr.Add(&componentHandler{})
+	cr.Add(&ComponentHandler{})
 }
 
-func (s *componentHandler) GetName() string {
+func (s *ComponentHandler) GetName() string {
 	return componentApi.DashboardComponentName
 }
 
-func (s *componentHandler) Init(platform common.Platform) error {
-	mi := defaultManifestInfo(platform)
+func (s *ComponentHandler) Init(platform common.Platform) error {
+	mi := DefaultManifestInfo(platform)
 
-	if err := odhdeploy.ApplyParams(mi.String(), "params.env", imagesMap); err != nil {
+	if err := odhdeploy.ApplyParams(mi.String(), "params.env", ImagesMap); err != nil {
 		return fmt.Errorf("failed to update images on path %s: %w", mi, err)
 	}
 
-	extra := bffManifestsPath()
-	if err := odhdeploy.ApplyParams(extra.String(), "params.env", imagesMap); err != nil {
+	extra := BffManifestsPath()
+	if err := odhdeploy.ApplyParams(extra.String(), "params.env", ImagesMap); err != nil {
 		return fmt.Errorf("failed to update modular-architecture images on path %s: %w", extra, err)
 	}
 
 	return nil
 }
 
-func (s *componentHandler) NewCRObject(dsc *dscv1.DataScienceCluster) common.PlatformObject {
+func (s *ComponentHandler) NewCRObject(dsc *dscv1.DataScienceCluster) common.PlatformObject {
 	return &componentApi.Dashboard{
 		TypeMeta: metav1.TypeMeta{
 			Kind:       componentApi.DashboardKind,
@@ -65,18 +65,27 @@ func (s *componentHandler) NewCRObject(dsc *dscv1.DataScienceCluster) common.Pla
 	}
 }
 
-func (s *componentHandler) IsEnabled(dsc *dscv1.DataScienceCluster) bool {
+func (s *ComponentHandler) IsEnabled(dsc *dscv1.DataScienceCluster) bool {
 	return dsc.Spec.Components.Dashboard.ManagementState == operatorv1.Managed
 }
 
-func (s *componentHandler) UpdateDSCStatus(ctx context.Context, rr *types.ReconciliationRequest) (metav1.ConditionStatus, error) {
+func (s *ComponentHandler) UpdateDSCStatus(ctx context.Context, rr *types.ReconciliationRequest) (metav1.ConditionStatus, error) {
 	cs := metav1.ConditionUnknown
 
+	if rr.Client == nil {
+		return cs, errors.New("client is nil")
+	}
+
 	c := componentApi.Dashboard{}
 	c.Name = componentApi.DashboardInstanceName
 
-	if err := rr.Client.Get(ctx, client.ObjectKeyFromObject(&c), &c); err != nil && !k8serr.IsNotFound(err) {
-		return cs, nil
+	dashboardCRExists := true
+	if err := rr.Client.Get(ctx, client.ObjectKeyFromObject(&c), &c); err != nil {
+		if k8serr.IsNotFound(err) {
+			dashboardCRExists = false
+		} else {
+			return cs, fmt.Errorf("failed to get Dashboard CR: %w", err)
+		}
 	}
 
 	dsc, ok := rr.Instance.(*dscv1.DataScienceCluster)
@@ -92,7 +101,7 @@ func (s *componentHandler) UpdateDSCStatus(ctx context.Context, rr *types.Reconc
 
 	rr.Conditions.MarkFalse(ReadyConditionType)
 
-	if s.IsEnabled(dsc) {
+	if s.IsEnabled(dsc) && dashboardCRExists {
 		dsc.Status.InstalledComponents[LegacyComponentNameUpstream] = true
 		dsc.Status.Components.Dashboard.DashboardCommonStatus = c.Status.DashboardCommonStatus.DeepCopy()
 
@@ -109,6 +118,13 @@ func (s *componentHandler) UpdateDSCStatus(ctx context.Context, rr *types.Reconc
 			conditions.WithMessage("Component ManagementState is set to %s", string(ms)),
 			conditions.WithSeverity(common.ConditionSeverityInfo),
 		)
+		// For Removed and Unmanaged states, condition should be Unknown
+		// For Managed state without Dashboard CR, condition should be False
+		if ms == operatorv1.Managed {
+			cs = metav1.ConditionFalse
+		} else {
+			cs = metav1.ConditionUnknown
+		}
 	}
 
 	return cs, nil

internal/controller/components/dashboard/dashboard_controller.go

@@ -18,6 +18,7 @@ package dashboard
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	consolev1 "github.com/openshift/api/console/v1"
@@ -45,8 +46,12 @@ import (
 )
 
 // NewComponentReconciler creates a ComponentReconciler for the Dashboard API.
-func (s *componentHandler) NewComponentReconciler(ctx context.Context, mgr ctrl.Manager) error {
-	componentName := computeComponentName()
+func (s *ComponentHandler) NewComponentReconciler(ctx context.Context, mgr ctrl.Manager) error {
+	if mgr == nil {
+		return errors.New("could not create the dashboard controller: manager cannot be nil")
+	}
+
+	componentName := ComputeComponentName()
 
 	_, err := reconciler.ReconcilerFor(mgr, &componentApi.Dashboard{}).
 		// operands - owned
@@ -97,7 +102,7 @@ func (s *componentHandler) NewComponentReconciler(ctx context.Context, mgr ctrl.
 		}), reconciler.Dynamic(reconciler.CrdExists(gvk.DashboardHardwareProfile))).
 		WithAction(initialize).
 		WithAction(devFlags).
-		WithAction(setKustomizedParams).
+		WithAction(SetKustomizedParams).
 		WithAction(configureDependencies).
 		WithAction(kustomize.NewAction(
 			// Those are the default labels added by the legacy deploy method
@@ -111,10 +116,10 @@ func (s *componentHandler) NewComponentReconciler(ctx context.Context, mgr ctrl.
 			kustomize.WithLabel(labels.ODH.Component(componentName), labels.True),
 			kustomize.WithLabel(labels.K8SCommon.PartOf, componentName),
 		)).
-		WithAction(customizeResources).
+		WithAction(CustomizeResources).
 		WithAction(deploy.NewAction()).
 		WithAction(deployments.NewAction()).
-		WithAction(reconcileHardwareProfiles).
+		WithAction(ReconcileHardwareProfiles).
 		WithAction(updateStatus).
 		// must be the final action
 		WithAction(gc.NewAction(