-
Notifications
You must be signed in to change notification settings - Fork 122
RHAIENG-389: Change RStudio base-image to AIPCC #2642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
RHAIENG-389: Change RStudio base-image to AIPCC #2642
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fc6bcd1 to
7248601
Compare
7248601 to
e0135b3
Compare
| RUN dnf install -y 'dnf-command(config-manager)' && \ | ||
| dnf config-manager --set-enabled crb && \ | ||
| dnf install -y https://download.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm && \ | ||
| RUN dnf install -y https://download.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ysok what packages are installed from this? can you provide a list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
Installing:
R-Rcpp x86_64 1.1.0-1.el9 epel 1.7 M
R-core x86_64 4.5.1-1.el9 epel 66 M
R-core-devel x86_64 4.5.1-1.el9 epel 90 k
R-highlight x86_64 0.5.1-11.el9 epel 539 k
R-java x86_64 4.5.1-1.el9 epel 9.2 k
R-littler x86_64 0.3.19-8.el9 epel 70 k
R-littler-examples x86_64 0.3.19-8.el9 epel 33 k
...
libRmath x86_64 4.5.1-1.el9 epel 121 k
libRmath-devel x86_64 4.5.1-1.el9 epel 15 k
...
libdeflate x86_64 1.24-1.el9 epel 62 k
libdeflate-devel x86_64 1.24-1.el9 epel 15 k
...
libtidy x86_64 5.8.0-2.el9 epel 244 k
...
tre x86_64 0.8.0-34.20140228gitc2f5d13.el9 epel 42 k
tre-common noarch 0.8.0-34.20140228gitc2f5d13.el9 epel 31 k
tre-devel x86_64 0.8.0-34.20140228gitc2f5d13.el9 epel 12 k
...
tidy x86_64 5.8.0-2.el9 epel 36 k
...
libgit2-devel x86_64 1.7.2-2.el9 epel 258 k
...
libgit2 x86_64 1.7.2-2.el9 epel 524 k
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the necessary packages should be rebuilt in https://copr.devel.redhat.com/coprs/mcurlej/rstudio-server-dependencies/packages/. If they aren't we need to re-request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be dnf prefers epel over the copr repo? If yes, we need it the other way around. Disable epel, or only install what's currently missing from epel and then disable epel for the rest of the build, so that the copr repo is used instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiridanek looks like libgit2-devel.x86_64 is the one came from Epel. In my local showing R came from that COPR.
Btw, now I am trying to switch/test it using my employee activation key instead.
e0135b3 to
4993fa7
Compare
4993fa7 to
b98fec5
Compare
b98fec5 to
08bda69
Compare
Begin by using the provided AIPCC base image and the copr of rstudio-server-dependencies to pass-through dnf upgrade. In the meantime, we are installing other dependencies using mirror.stream.centos.org while we await the final working AIPCC image.
08bda69 to
1ce2846
Compare
Begin by using the provided AIPCC base image and the copr of rstudio-server-dependencies to pass-through dnf upgrade. In the meantime, we are installing other dependencies using mirror.stream.centos.org while we await the final working AIPCC image.
How Has This Been Tested?
Local test using podman:
podman build --no-cache -f rstudio/c9s-python-3.12/Dockerfile.cpu --platform linux/x86_64 --build-arg BASE_IMAGE=quay.io/aipcc/base-images/cpu:3.0 -t rstudio-c9s-python-3.12 .Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: