Skip to content

Conversation

@ysok
Copy link
Contributor

@ysok ysok commented Nov 4, 2025

Begin by using the provided AIPCC base image and the copr of rstudio-server-dependencies to pass-through dnf upgrade. In the meantime, we are installing other dependencies using mirror.stream.centos.org while we await the final working AIPCC image.

How Has This Been Tested?

Local test using podman:
podman build --no-cache -f rstudio/c9s-python-3.12/Dockerfile.cpu --platform linux/x86_64 --build-arg BASE_IMAGE=quay.io/aipcc/base-images/cpu:3.0 -t rstudio-c9s-python-3.12 .

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign harshad16 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel label Nov 4, 2025
@openshift-ci openshift-ci bot added the size/s label Nov 4, 2025
@ysok ysok force-pushed the RHAIENG-389-rstudio-dockerfile-aipcc branch from fc6bcd1 to 7248601 Compare November 4, 2025 03:53
@openshift-ci openshift-ci bot added size/s and removed size/s labels Nov 4, 2025
@ysok ysok force-pushed the RHAIENG-389-rstudio-dockerfile-aipcc branch from 7248601 to e0135b3 Compare November 4, 2025 13:07
@openshift-ci openshift-ci bot added size/s and removed size/s labels Nov 4, 2025
RUN dnf install -y 'dnf-command(config-manager)' && \
dnf config-manager --set-enabled crb && \
dnf install -y https://download.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm && \
RUN dnf install -y https://download.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysok what packages are installed from this? can you provide a list?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/open-data-hub-tenant/applications/opendatahub-release/pipelineruns/odh-workbench-rstudio-minimal-cuda-py312-c9s-on-pull-requen6lwf

I see

 Installing:
   R-Rcpp                                 x86_64  1.1.0-1.el9                     epel       1.7 M
   R-core                                 x86_64  4.5.1-1.el9                     epel        66 M
   R-core-devel                           x86_64  4.5.1-1.el9                     epel        90 k
   R-highlight                            x86_64  0.5.1-11.el9                    epel       539 k
   R-java                                 x86_64  4.5.1-1.el9                     epel       9.2 k
   R-littler                              x86_64  0.3.19-8.el9                    epel        70 k
   R-littler-examples                     x86_64  0.3.19-8.el9                    epel        33 k
...
   libRmath                               x86_64  4.5.1-1.el9                     epel       121 k
   libRmath-devel                         x86_64  4.5.1-1.el9                     epel        15 k
...
   libdeflate                             x86_64  1.24-1.el9                      epel        62 k
   libdeflate-devel                       x86_64  1.24-1.el9                      epel        15 k
...
   libtidy                                x86_64  5.8.0-2.el9                     epel       244 k
...
   tre                                    x86_64  0.8.0-34.20140228gitc2f5d13.el9 epel        42 k
   tre-common                             noarch  0.8.0-34.20140228gitc2f5d13.el9 epel        31 k
   tre-devel                              x86_64  0.8.0-34.20140228gitc2f5d13.el9 epel        12 k
...
   tidy                                   x86_64  5.8.0-2.el9                     epel        36 k
...
   libgit2-devel                x86_64    1.7.2-2.el9          epel         258 k
...
   libgit2                      x86_64    1.7.2-2.el9          epel         524 k

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the necessary packages should be rebuilt in https://copr.devel.redhat.com/coprs/mcurlej/rstudio-server-dependencies/packages/. If they aren't we need to re-request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be dnf prefers epel over the copr repo? If yes, we need it the other way around. Disable epel, or only install what's currently missing from epel and then disable epel for the rest of the build, so that the copr repo is used instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiridanek looks like libgit2-devel.x86_64 is the one came from Epel. In my local showing R came from that COPR.

image

Btw, now I am trying to switch/test it using my employee activation key instead.

@ysok ysok force-pushed the RHAIENG-389-rstudio-dockerfile-aipcc branch from e0135b3 to 4993fa7 Compare November 4, 2025 16:48
@openshift-ci openshift-ci bot added size/m and removed size/s labels Nov 4, 2025
@ysok ysok force-pushed the RHAIENG-389-rstudio-dockerfile-aipcc branch from 4993fa7 to b98fec5 Compare November 4, 2025 17:50
@openshift-ci openshift-ci bot added size/m and removed size/m labels Nov 4, 2025
@ysok ysok force-pushed the RHAIENG-389-rstudio-dockerfile-aipcc branch from b98fec5 to 08bda69 Compare November 4, 2025 17:51
@openshift-ci openshift-ci bot added size/m and removed size/m labels Nov 4, 2025
Begin by using the provided AIPCC base image and the copr of rstudio-server-dependencies to pass-through dnf upgrade. In the meantime, we are installing other dependencies using mirror.stream.centos.org while we await the final working AIPCC image.
@ysok ysok force-pushed the RHAIENG-389-rstudio-dockerfile-aipcc branch from 08bda69 to 1ce2846 Compare November 4, 2025 18:07
@openshift-ci openshift-ci bot added size/m and removed size/m labels Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants