Optimization ximgproc::thinning#3801
Open
sturkmen72 wants to merge 1 commit intoopencv:4.xfrom
Open
Conversation
|
@sturkmen72 Thanks for crediting me! I'm fine with releasing this code under another license if that's useful. Apache License v2.0 appears to be the same though. In any case, I fully support this merge request :-) |
Contributor
Author
|
@ulikoehler Performance increase almost doubled. let me try to find out why GUOHALL gives different result |
6246fad to
d6c0c94
Compare
Contributor
Author
|
@vrabaud could you take a look |
vrabaud
approved these changes
Oct 3, 2024
Contributor
vrabaud
left a comment
There was a problem hiding this comment.
Nice clean-up ! And faster too.
Contributor
Author
|
Please merge the PR #3750 (tested manually) before this PR to give proper credit, as this PR is based on it. |
e7d828a to
66cf9b3
Compare
c8ca52b to
f5d4b06
Compare
asmorkalov
approved these changes
Oct 9, 2024
Contributor
Author
|
@asmorkalov what is your opinion merging the PR #3750 (tested manually) before this PR to give proper credit, as this PR is based on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
credits @ulikoehler https://github.com/ulikoehler/cv_algorithms
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.