Skip to content

Conversation

@ricardobranco777
Copy link
Contributor

@ricardobranco777 ricardobranco777 commented Jan 2, 2026

Skip test for new privileges if NoNewPrivs is set.

Otherwise the test for https://www.thkukuk.de/blog/no_new_privs/ will fail:
https://openqa.opensuse.org/tests/5575299

Verification run: https://openqa.opensuse.org/tests/5575346

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit, lgtm otherwise

}

@test "runc run with new privileges" {
if [ $(awk '/^NoNewPrivs:/ { print $2 }' /proc/self/status) -ne 0 ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

awk '$1 == "NoNewPrivs:" { print $2; exit }' 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@kolyshkin kolyshkin enabled auto-merge January 6, 2026 00:49
@kolyshkin kolyshkin merged commit ed01e20 into opencontainers:main Jan 6, 2026
35 of 37 checks passed
@lifubang
Copy link
Member

lifubang commented Jan 6, 2026

@kolyshkin I noticed CI failures in the following runs:
https://github.com/opencontainers/runc/actions/runs/20732953175/job/59527702150
https://github.com/opencontainers/runc/actions/runs/20734101166/job/59527954096
Opened #5080 to address.
@ricardobranco777 PTAL

@ricardobranco777 ricardobranco777 deleted the no_new_privs branch January 6, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants